Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The SBI Beaker #1447

Merged
merged 11 commits into from
Jun 15, 2024
Merged

The SBI Beaker #1447

merged 11 commits into from
Jun 15, 2024

Conversation

UncaughtEx
Copy link
Contributor

About the PR

Adds the SBI Beaker, a Chemistry focused ship with a closed off Atmos setup.

Why / Balance

I've noticed in the wide array of ships we have on offer, that we lack a purely Chemistry option.

How to test

Spawn in
Buy Beaker from Shipyard
COOK

Media

image

  • I have added screenshots/videos to this PR showcasing its changes ingame

Changelog
🆑

  • add: With permission from the NT Pharmaceuticals branch, fresh from the Fabs, SBI would like to introduce the Beaker Shipyard License approved for distribution! Yeah, Science!

@github-actions github-actions bot added Map-Shuttle Map - Shuttle No C# labels May 30, 2024
@MagnusCrowe
Copy link
Contributor

Chemistry ship, my beloved.

@ThatOneGoblin25
Copy link
Contributor

Consider swapping the docking airlocks to glass variants, and the maints airlocks to the thrusters to red external airlocks.

@UncaughtEx
Copy link
Contributor Author

Consider swapping the docking airlocks to glass variants, and the maints airlocks to the thrusters to red external airlocks.

I like the idea of the airlocks being opaque since it gives the Ship a more concealed feel.
As for the thruster airlocks, I think the dilating airlocks add to the aesthetic.

@MagnusCrowe
Copy link
Contributor

MagnusCrowe commented Jun 3, 2024

Consider swapping the docking airlocks to glass variants, and the maints airlocks to the thrusters to red external airlocks.

I like the idea of the airlocks being opaque since it gives the Ship a more concealed feel. As for the thruster airlocks, I think the dilating airlocks add to the aesthetic.

They aren't wrong about the red airlocks. If you want an external door, it should be obvious to players that it is an external door.

That being said, I'm open to the creation of new styles of external doors. If you want a cool aperture door like that, you'll want to create a new one that unambiguously indicates that it is a door to space. That's going to involve creating/finding a new sprite and creating a prototype for the door.

I don't care if you use opaque or clear docking ports, that's up to you.

@UncaughtEx
Copy link
Contributor Author

Consider swapping the docking airlocks to glass variants, and the maints airlocks to the thrusters to red external airlocks.

I like the idea of the airlocks being opaque since it gives the Ship a more concealed feel. As for the thruster airlocks, I think the dilating airlocks add to the aesthetic.

They aren't wrong about the red airlocks. If you want an external door, it should be obvious to players that it is an external door.

That being said, I'm open to the creation of new styles of external doors. If you want a cool aperture door like that, you'll want to create a new one that unambiguously indicates that it is a door to space. That's going to involve creating/finding a new sprite and creating a prototype for the door.

I don't care if you use opaque or clear docking ports, that's up to you.

Then I concede on the thruster airlocks, I'll change them over when I get a chance.

@UncaughtEx
Copy link
Contributor Author

image

@MagnusCrowe
Copy link
Contributor

image
Can I recommend you to treat the superpacman as if it were radioactive? Just incase we decide to make that generator emit radiation in the future?

@UncaughtEx
Copy link
Contributor Author

Recommendation noted
Ill add the suggested changes in a bit

@UncaughtEx
Copy link
Contributor Author

Made the engineering a bit more rad proof
Added an engineering access locked button

@UncaughtEx
Copy link
Contributor Author

image

Copy link
Contributor

@MagnusCrowe MagnusCrowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@MagnusCrowe MagnusCrowe merged commit 5f937d0 into new-frontiers-14:master Jun 15, 2024
12 checks passed
FrontierATC added a commit that referenced this pull request Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants