Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selective dropper for Service Roles #1425

Closed
wants to merge 113 commits into from

Conversation

blueDev2
Copy link
Contributor

About the PR

Added a new entity, Service Selective Dropper
Act identically to a dropper except it a player may right click it to have the dropper only draw a certain reagent
The Service Selective Dropper only works on can discriminate on reagents that are in the Botanical, Foods, or Drinks Groups.

In terms of code, the entity depends on a new field on the InjectorComponent, ReagentWhitelist. If the ReagentWhitelist is null, all reagents are allowed to be drawn. Otherwise, only reagents on the ReagentWhitelist may be drawn.

A new Component, ReagentWhitelistChangeComponent, allows a UI to change the ReagentWhitelist if the new reagent is from a group in the AllowedReagentGroup field. Changint the whitelist using this component, the whitelist can have, at most, one reagent.

Why / Balance

The main purpose of this entity is to allow chefs to remove certain contaminants, like nutriment in flour, from baking solutions.
For discussion, please look at the discord ideas thread on "Separate reagents with dropper"

Media

video1120447917.mp4
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑 blueDev2

  • add: Added the Service Selective Dropper to help chefs make purer food

@github-actions github-actions bot added the S: Merge Conflict This PR has conflicts that prevent merging label Jun 3, 2024
Copy link
Contributor

github-actions bot commented Jun 3, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added Docs Improvements or additions to documentation S: Merge Conflict This PR has conflicts that prevent merging Map-Shuttle Map - Shuttle Map-POI Map - POI Map-Bluespace Map - Bluespace Event Map-Outpost Map - Outpost and removed S: Merge Conflict This PR has conflicts that prevent merging YML labels Jun 5, 2024
@blueDev2
Copy link
Contributor Author

blueDev2 commented Jun 5, 2024

Closed to be fixed after disastrous rebase

@blueDev2 blueDev2 closed this Jun 5, 2024
@blueDev2 blueDev2 deleted the Selective-Dropper branch June 5, 2024 17:05
@blueDev2 blueDev2 restored the Selective-Dropper branch June 5, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# Docs Improvements or additions to documentation FTL Map-Bluespace Map - Bluespace Event Map-Outpost Map - Outpost Map-POI Map - POI Map-Shuttle Map - Shuttle S: Merge Conflict This PR has conflicts that prevent merging Sprites UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.