Rubber Bullets #1388
Merged
Rubber Bullets #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvir001
added
S: Awaiting Changes
dvir001
added
S: Needs Review
|
Done |
whatston3
requested changes
May 25, 2024
There was a problem hiding this comment.
Changes look good. Only thing I think is a bit strange is how the rubber cartridges that spawn in non-lethal revolvers are copper-jacketed instead of painted blue. Looking into that for curiosity, otherwise looks good.
I've pushed whitespace YAML cleanup onto a branch on my repo (GitHub). Requesting changes only for cleanup.
whatston3
reviewed
May 25, 2024
Resources/Prototypes/_NF/Entities/Objects/Weapons/Guns/SMGs/smgs.yml
Outdated
Show resolved
Hide resolved
1 task
GreaseMonk
approved these changes
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Restore all rubber bullets
Why / Balance
No need to be removed
How to test
Items are back, spawn menu
Media
N/A
Breaking changes
N/A
Changelog
🆑 dvir01