Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update labeler.yml #1328

Merged
merged 2 commits into from
May 3, 2024
Merged

Update labeler.yml #1328

merged 2 commits into from
May 3, 2024

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented May 3, 2024

Adding missing regex

@dvir001 dvir001 requested review from Cheackraze, MagnusCrowe, FrontierATC and GreaseMonk and removed request for FrontierATC May 3, 2024 01:34
@github-actions github-actions bot added No C# S: Needs Review This PR is awaiting reviews labels May 3, 2024
whatston3
whatston3 reviewed May 3, 2024
View reviewed changes
Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all of the entries here, is there a reason to avoid use of double stars (**)? As far as I understand, this would include both the base folder and all subfolders.

.github/labeler.yml Outdated Show resolved Hide resolved
.github/labeler.yml Outdated Show resolved Hide resolved
.github/labeler.yml Outdated Show resolved Hide resolved
.github/labeler.yml Outdated Show resolved Hide resolved
.github/labeler.yml Outdated Show resolved Hide resolved
@dvir001 dvir001 merged commit 5a34577 into new-frontiers-14:master May 3, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whatston3 whatston3 whatston3 left review comments

@MagnusCrowe MagnusCrowe MagnusCrowe approved these changes

@Cheackraze Cheackraze Awaiting requested review from Cheackraze

@GreaseMonk GreaseMonk Awaiting requested review from GreaseMonk

Assignees
No one assigned
Labels
No C# S: Needs Review This PR is awaiting reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dvir001 @MagnusCrowe @whatston3