Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pioneer (Update) + Guidebook #1321

Merged
merged 6 commits into from
May 6, 2024

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented May 2, 2024

About the PR

Cleaned the table a bit from junk
Replaced the generator with a ship one
No more errors?

Why / Balance

Cleanup

How to test

Start and spawn ship

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

image

Breaking changes

N/A

Changelog
N/A

@github-actions github-actions bot added Map-Shuttle Map - Shuttle No C# labels May 2, 2024
@dvir001 dvir001 requested a review from MagnusCrowe May 2, 2024 00:21
@github-actions github-actions bot added the S: Needs Review This PR is awaiting reviews label May 2, 2024
@ErhardSteinhauer
Copy link
Contributor

Can you move the air scrubber to the place where the air sensor is? And ditch the sensor then.

@MagnusCrowe
Copy link
Contributor

Can you move the air scrubber to the place where the air sensor is? And ditch the sensor then.

Why bother moving the scrubber? Just remove the sensor. It's useless when placed next to the vent.

@dvir001
Copy link
Contributor Author

dvir001 commented May 2, 2024

Can you move the air scrubber to the place where the air sensor is? And ditch the sensor then.

Why bother moving the scrubber? Just remove the sensor. It's useless when placed next to the vent.

Ill replace it, sure.

@dvir001 dvir001 added S: Awaiting Changes This PR has changes that need to be made before merging and removed S: Needs Review This PR is awaiting reviews labels May 2, 2024
@github-actions github-actions bot added Docs Improvements or additions to documentation FTL labels May 2, 2024
@dvir001 dvir001 changed the title Pioneer (Update) Pioneer (Update) + Guidebook May 3, 2024
@dvir001
Copy link
Contributor Author

dvir001 commented May 3, 2024

Can you move the air scrubber to the place where the air sensor is? And ditch the sensor then.

Why bother moving the scrubber? Just remove the sensor. It's useless when placed next to the vent.

Ill replace it, sure.

Fixed

@dvir001 dvir001 added S: Needs Review This PR is awaiting reviews and removed S: Awaiting Changes This PR has changes that need to be made before merging labels May 3, 2024
@MagnusCrowe MagnusCrowe merged commit bc6bbc6 into new-frontiers-14:master May 6, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Improvements or additions to documentation FTL Map-Shuttle Map - Shuttle No C# S: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants