Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ion storms system-wide instead of shuttle-local #1314

Merged
merged 1 commit into from
May 1, 2024

Conversation

whatston3
Copy link
Contributor

About the PR

Makes ion storm events randomly change laws to all cyborgs in the sector (including in space), rather than only when on one randomly selected shuttle.

Why / Balance

Rule as-is on master meant ion storms rarely affected cyborgs. This makes law changes much more frequent, and should be more suitable for a setting like Frontier Station with many shuttles.

How to test

Build and run local server.
With the sandbox commands, spawn a cyborg on Frontier Outpost.
Switch control to cyborg - stay on station.
Enter /addgamerule IonStorm into chat until your laws change.
Should be quick on branch to be merged, should never happen on master.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

tweak: Increased system-wide electromagnetic interference.

@github-actions github-actions bot added the C# label May 1, 2024
@dvir001 dvir001 self-requested a review May 1, 2024 15:10
@github-actions github-actions bot added the S: Needs Review This PR is awaiting reviews label May 1, 2024
@dvir001
Copy link
Contributor

dvir001 commented May 1, 2024

Still not working on frontier itself

Can be fixed later..

@dvir001 dvir001 merged commit 584f618 into new-frontiers-14:master May 1, 2024
13 checks passed
@whatston3
Copy link
Contributor Author

Still not working on frontier itself

Can be fixed later..

For what it's worth, I rebuilt and tested this. Two cyborgs on Frontier, two ~30m outside, no ships spawned in. Add game rule for event once. All four have different wonky laws. I can't see what would cause this.

@whatston3 whatston3 deleted the 2024-05-01-ionstormfix branch May 2, 2024 11:15
Vonsant pushed a commit to Corvax-Frontier/corvax-frontier-14 that referenced this pull request May 2, 2024
dvir001 added a commit that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# S: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants