Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging extensions #1286

Merged
merged 1 commit into from
Apr 27, 2024
Merged

Add logging extensions #1286

merged 1 commit into from
Apr 27, 2024

Conversation

GreaseMonk
Copy link
Contributor

About the PR

This PR adds extra logging for entities with a stack component, now tells how much is in the stack.

Why / Balance

Logs currently dont show how much , for example, spesos are in a stack when people pick it up with their hands.

How to test

Interact, drop, pick up, deposit spesos and check admin entity logs. it should now properly display the amount of things in anything with a stack component.

Media

Before::
image

After:
image

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • tweak: Add more info about stack count to entity logs

@github-actions github-actions bot added the C# label Apr 27, 2024
@dvir001 dvir001 requested review from dvir001 and Cheackraze April 27, 2024 11:27
@dvir001
Copy link
Contributor

dvir001 commented Apr 27, 2024

Holy based

Also you can make Changelog admin only

@github-actions github-actions bot added the S: Needs Review This PR is awaiting reviews label Apr 27, 2024
Copy link
Contributor

@dvir001 dvir001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works ™️

My only fear is something upstream breaking it so we might want to consider also making this PR there, but overall this seems fine.

@GreaseMonk
Copy link
Contributor Author

Works ™️

My only fear is something upstream breaking it so we might want to consider also making this PR there, but overall this seems fine.

they can also make some abstraction in robust toolbox

@GreaseMonk GreaseMonk merged commit 363ebce into master Apr 27, 2024
14 checks passed
@GreaseMonk GreaseMonk deleted the bugfix/spesos-logging branch April 27, 2024 12:36
FrontierATC added a commit that referenced this pull request Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# S: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants