Reimplement shuttle designation #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cheackraze
approved these changes
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Add ship designation to shuttle console UI. Reimplementation of #795
Why / Balance
This solves the problem of ship designations being annoying to remember/track when you need them.
Technical details
Replaces the text "Display" above the ReadonlyDisplay with the name of the ship. (If the ship is a POI or something without a 6-character designation, it uses the whole ship name. Otherwise, it uses everything except the designation)
Performs as its predecessor implementation, except more efficiently, as it only sets the name once per shuttle Uid set, instead of once every screen draw.
Also adds two Labels to the ShuttleConsoleWindow's ReadonlyDisplay:
Media
Breaking changes
N/A
Changelog
🆑