Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement shuttle designation #1283

Closed

Conversation

GingerAvalanche
Copy link
Contributor

About the PR

Add ship designation to shuttle console UI. Reimplementation of #795

Why / Balance

This solves the problem of ship designations being annoying to remember/track when you need them.

Technical details

Replaces the text "Display" above the ReadonlyDisplay with the name of the ship. (If the ship is a POI or something without a 6-character designation, it uses the whole ship name. Otherwise, it uses everything except the designation)

Performs as its predecessor implementation, except more efficiently, as it only sets the name once per shuttle Uid set, instead of once every screen draw.

Also adds two Labels to the ShuttleConsoleWindow's ReadonlyDisplay:

  • Text "Designation:"
  • ShuttleDesignation, the 6-character designation of the current ship, or "Unknown" if it does not have a designation

Media

image
image

  • I have added screenshots/videos to this PR showcasing its changes ingame,

Breaking changes

N/A

Changelog

🆑

  • add: Shuttle console display UI now shows ship name and designation

Copy link
Contributor

Thank you for contributing to the Space Station 14 repository. Unfortunately, it looks like you submitted your pull request from the master branch. We suggest you follow our git usage documentation

You can move your current work from the master branch to another branch by doing git branch <branch_name and resetting the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant