Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pirate Cove (Update) #1281

Merged
merged 13 commits into from
Apr 27, 2024
Merged

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Apr 26, 2024

About the PR

Added the fixgridatmo command fix PR, since I could not do this PR without it.
Redid the pirate cove based on a "ship crashed a large meteore" idea.
Added a new IFF computer that cannot be broken, moved, or disassembled with a new IFF that only allow change of "hidden" status to allow the pirate cove and the syndicate point bravo to be set to be hidden.
Change the Freelance and Syndicate radio to no longer be global and require servers, moved the servers to POI (Pirate to pirate, syndicate to syndicate).
Fixed an issue with some machines and computer that were able to be broken for board (Hydro tray)
Added new water that is decorative to be used under catwalks.
Gave Clarrrrpy the FreelanceTrackingImplant to replace the syndicate one.

Why / Balance

Long time coming, with the new pirates system under work I think its time for a facelift.

How to test

Run the game, warp to the new pirate cove.

Media

Mapping mod:

Docking area
image

Cave start
image

Middle of cave
image

Side area
image

Top area
image

Far render
image

In game:

Docking area
image

Cave start
image

Middle of cave
image

Side area
image

Top area
image

Far render
image

Breaking changes

N/A

Changelog
🆑 dvir01

  • tweak: The pirates moved to a new base, McCove if you will.

@github-actions github-actions bot added S: Needs Review This PR is awaiting reviews Map-POI Map - POI Sprites C# labels Apr 26, 2024
Copy link
Contributor

github-actions bot commented Apr 26, 2024

RSI Diff Bot; head commit 5f16251 merging into 3f800f8
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:
Edit: diff updated after 5f16251

@WallaceLordofOwls
Copy link

The cave looks like it's open to the vacuum of space along those tan areas on the left and top part of the cove. Is that the case?

@dvir001
Copy link
Contributor Author

dvir001 commented Apr 27, 2024

The cave looks like it's open to the vacuum of space along those tan areas on the left and top part of the cove. Is that the case?

Why make the claim if you didn't test in game.
It's not.

If you mean just "in space" yes after the airlock with the mini fan its space, you have eva suits next to that airlock.

@MagnusCrowe MagnusCrowe merged commit 6ca1d30 into new-frontiers-14:master Apr 27, 2024
14 checks passed
FrontierATC added a commit that referenced this pull request Apr 27, 2024
@WallaceLordofOwls
Copy link

@dvir001 Hi dvir, absolutely love the new cove updates, but I noticed two potential issues with the updated cove. Firstly, the soda dispenser doesn't have any soda in it, which I assume is an oversight.

The other thing is that the pirate cove has Frontier sell values, instead of cargo depot values. I think it's a lot better to have pirates head back to the cove and sell their stuff there instead of awkwardly sneaking to a depot to sell, so if it could be changed to be depot sell values that would encourage pirates to sell at the cove.

@dvir001
Copy link
Contributor Author

dvir001 commented Apr 30, 2024

@dvir001 Hi dvir, absolutely love the new cove updates, but I noticed two potential issues with the updated cove. Firstly, the soda dispenser doesn't have any soda in it, which I assume is an oversight.

The other thing is that the pirate cove has Frontier sell values, instead of cargo depot values. I think it's a lot better to have pirates head back to the cove and sell their stuff there instead of awkwardly sneaking to a depot to sell, so if it could be changed to be depot sell values that would encourage pirates to sell at the cove.

This 2 things are 100% intended, soda empty but boze full is a joke

The low sell was asked by check to be added.

Cove can go full IFF off also

@WallaceLordofOwls
Copy link

@dvir001 Hi dvir, absolutely love the new cove updates, but I noticed two potential issues with the updated cove. Firstly, the soda dispenser doesn't have any soda in it, which I assume is an oversight.
The other thing is that the pirate cove has Frontier sell values, instead of cargo depot values. I think it's a lot better to have pirates head back to the cove and sell their stuff there instead of awkwardly sneaking to a depot to sell, so if it could be changed to be depot sell values that would encourage pirates to sell at the cove.

This 2 things are 100% intended, soda empty but boze full is a joke

The low sell was asked by check to be added.

Cove can go full IFF off also

Understood, thanks for the response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# Map-POI Map - POI S: Needs Review This PR is awaiting reviews Sprites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants