Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ent locale #1279

Merged
merged 4 commits into from
Apr 26, 2024
Merged

Conversation

lzk228
Copy link
Contributor

@lzk228 lzk228 commented Apr 26, 2024

About the PR

Move entities names and descritions from ftl to yml
resolves #1275

Why / Balance

#1275 and space-wizards/space-station-14#24159

How to test

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

@dvir001 dvir001 self-requested a review April 26, 2024 12:36
@github-actions github-actions bot added the S: Needs Review This PR is awaiting reviews label Apr 26, 2024
@lzk228 lzk228 requested a review from dvir001 April 26, 2024 12:43
@lzk228 lzk228 requested a review from dvir001 April 26, 2024 16:43
Copy link
Contributor

@dvir001 dvir001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually done now, merge when its done running tests.

@dvir001 dvir001 merged commit 51c0ae3 into new-frontiers-14:master Apr 26, 2024
12 checks passed
@lzk228 lzk228 deleted the СУКАБЛЯТЬ branch April 26, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FTL No C# S: Needs Review This PR is awaiting reviews YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

entities locale should be removed
2 participants