Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gestio burst-fire 20 rifle #1277

Merged

Conversation

Qulibly
Copy link
Contributor

@Qulibly Qulibly commented Apr 26, 2024

About the PR

Adds a new civilian (class 1 contraband) tier 2 burst-fire marksman firearm to Frontier.
The caliber used is .20 rifle, same as Lecter, the NFSD assault rifle but also Argenti, tier 1 revolver.

It is obtainable through expeditions as a reward. In future if needed the methods of obtaining can be expanded.

Why / Balance

There is no burst-fire firearms out there. But mainly as people desperatly lacked a decent firearm option that isn't a contraband. As well as to expand options in the longer ranges category. A perfect middle option.

Balance wise weapon itself contains power when it stays in range.
And utilises its tempo: burst fire -> cover -> burst fire -> cover
Up close it will loose to options like shotguns, pistols, smgs and more.

It's design is to reward utilising the burst fire mode and heavily punishes trying to spam fire it.
As sadly due to how burst fire is coded it isn't possible to add a delay between bursts.
It is the reason why recoil approach was taken.

If it keeps its range and shooter approaches strategically, it is capable of beating lecter, or with team even a bloodred hardsuit with l6 saw.

When it comes to magazines. If people manage to somehow obtain standard sized .20 rifle magazines from NFSD, this can provide an improvement to firearm.
Conversely, NFSD could find use to low capacity magazines from Gestio, either to get more total shots at cost of needing to reload more. Or to fill in any empty slots in inventory with these smaller magazines to have more spare ammunition in case of need.

How to test

Ran through expedition, playtested on private server with people to test both PvE and PvP capabilities.
But also just spawn, pick it up and test fire on various targets and in varied situations

Media

2024-04-26.06-21-01.mp4
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

BaseWeaponRifle in yaml may potentially cause issues in the firearm if those changes vastly modify how weapon operates.

Changes to how burst-fire is coded in gun system.

Additionally balance could be diminished if standard sized Lecter magazines are easily obtainable to everyone.

Changelog

🆑

  • add: Added Gestio. A burst-fire .20 rifle, a tier 2 civilian firearm. It may be antique but could still prove useful to prospectors. Obtainable through expeditions.

Copy link
Contributor

github-actions bot commented Apr 26, 2024

RSI Diff Bot; head commit d078966 merging into 4805fdb
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Objects/Weapons/Gestio-Rifle.rsi

State Old New Status
base Added
bolt-open Added
equipped-BACKPACK Added
equipped-SUITSTORAGE Added
icon Added
inhand-left Added
inhand-right Added
mag-0 Added
wielded-inhand-left Added
wielded-inhand-right Added

Resources/Textures/_NF/Objects/Weapons/Low-Cap-Rifle-Magazine.rsi

State Old New Status
base Added
mag-1 Added
practice Added
red Added
rubber Added
uranium Added

Edit: diff updated after d078966

@Cheackraze
Copy link
Member

I think the burst is way to slow, and the time between firing is too quick as well, essentially turning this into almost an autofire weapon. In theory, I think we could allow a civilian burst fire rifle, but im not sure what ammo/damage we should really allow from it as well.

@github-actions github-actions bot added the S: Merge Conflict This PR has conflicts that prevent merging label Apr 29, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Qulibly
Copy link
Contributor Author

Qulibly commented Apr 30, 2024

I think the burst is way to slow, and the time between firing is too quick as well, essentially turning this into almost an autofire weapon. In theory, I think we could allow a civilian burst fire rifle, but im not sure what ammo/damage we should really allow from it as well.

Sadly when it comes to burst, if were to add a delay between firing I would need to touch the gun code and fixup the burst in there so you can actually add a delay. This is why went the recoil route. Burst speed is ok, definetly if could be faster it would be awesome but as now burst is "automatic but if you hold left click stops firing after X shots" cant get it too high either.

Given playtesting that done with few players it performed decently in PvP and PvE.

Damage wise, single burst deals 51 dmg without armor. Against NFSD armor it takes 3 perfectly accurate bursts to take down.

@github-actions github-actions bot removed the S: Merge Conflict This PR has conflicts that prevent merging label Apr 30, 2024
@Qulibly
Copy link
Contributor Author

Qulibly commented Apr 30, 2024

obraz
obraz

Tested ingame, all generates from expedition as it should. Spawner wise.
Hopefully will fit nicely as tier 2 firearm.

@dvir001
Copy link
Contributor

dvir001 commented May 19, 2024

Pull master into this PR please.

@whatston3 whatston3 mentioned this pull request May 29, 2024
1 task
@Qulibly
Copy link
Contributor Author

Qulibly commented Jun 7, 2024

Don't merge yet. Tested and wielding is completely borked on the gun as it wasn't made to be wielded.
WIll have to work to either fix that OR turn this gun into usable with one hand...

@Qulibly
Copy link
Contributor Author

Qulibly commented Jun 9, 2024

Now time to decide if sticking with .20 rifle caliber
OR
change it to .30 rifle caliber instead...

AS well as if expedition only OR make it purchasable in liberation vend...

@whatston3 whatston3 requested review from whatston3 June 9, 2024 01:50
@github-actions github-actions bot added the S: Needs Review This PR is awaiting reviews label Jun 9, 2024
@VividPups
Copy link
Contributor

no to the Vending because people will ONLY buy that also.. (honestly the Repeater shouldn't be in there and it should be buff really) it isn't legal because it is burst, you would need a permit. also, I would also say that the SVT is a chamber in 30cal but if this is posted to be an early Lector I would say keep it in the same Cal

@Leander-0
Copy link
Contributor

Again, dual-wielded argentis already act better than the gestio on this way, it should be a .30 with magazines of 15 bullets, then it can be upgraded with AKMS magazines or from the ammo techvend and yeah it should be available on the liberation vend along with magazines.

there is no point on getting a gestio from a gun case when i can get better weapons on the liberty vend already and with the same ammo and if you are on expedition you can get an AKMS more easily too on the syndicate expos.

@dvir001
Copy link
Contributor

dvir001 commented Jun 9, 2024

I would like to see it on expos like the AKMS

@github-actions github-actions bot added the S: Merge Conflict This PR has conflicts that prevent merging label Jun 12, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Qulibly
Copy link
Contributor Author

Qulibly commented Jun 14, 2024

Now question is. Where would it be better positioned?

Compared to dual-wielded argentis:
has lower capacity, may have lower accurancy, the bullets fly slightly faster, it may be easier to reload with magazines
if used one handed and with shield you may be capable to fire faster though without accurancy

As well as where it could fit?
Gestio most definetly is designed to be a fully legal weapon, with burst attempting to make it slightly more unique

@BluCottonCandy
Copy link

BluCottonCandy commented Jun 14, 2024

I think this is a solid weapon.
I dare say I think it belongs in the Lib Vend, I know this is probably an unpopular opinion.
However, it's slower than the Argenti, so DPS can not be the argument here.
It's got a small mag, and why would I choose this over any other SMG, or even the AKMS as it were.
I think this should be a round start weapon, if nothing else maybe make it obscenely expensive so people don't just grab it right away every single time.

As for why NT would sell it to us, were frontier, NT sells us their handmedowns all the time.
Why not sell the backwater NT space mining town these old ass rifles they found in a dusty supply closet?

EDIT: After extensive testing I can safely say this gun is better suited to Exped loot, and not round start purchasable.
Sure, the Argenti is stronger, but in the right hands, and given the ammount of ammo you can hold, this gun is very powerful.
Especially in a group of multiple people, it is quite powerful.
I am all for it being exped loot, and make it more common than the SMG's, because the SMG's are way to OP and way to common.
I would also like to add, it shoudl stay C1 I believe, as the Argenti is stupid broken, sawn off shotguns have always been stupid broken and IMO, this gun is only good at long range, if someone carries two sawn off shotguns and rushes up to you, you stand zero chance no matter how many guns and people you got.

It's well balanced, feels nice, but isn't sawn off shotgun broken.

@github-actions github-actions bot removed the S: Merge Conflict This PR has conflicts that prevent merging label Jun 15, 2024
@ErhardSteinhauer
Copy link
Contributor

Damn, resolving those conflicts took some effort.
Most of the changes made are related to expedition aspects: I've put Gestio on T2 of expedition weapon pool which should make it fairly common weapon, changed crate with Gestio rifles on expeds a bit and moved GestioExped prototype to the file where other exped weapon prototypes reside.

Copy link
Contributor

@ErhardSteinhauer ErhardSteinhauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works as expected: rifle rifles.

@github-actions github-actions bot added the S: Merge Conflict This PR has conflicts that prevent merging label Jun 19, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict This PR has conflicts that prevent merging label Jun 19, 2024
@ErhardSteinhauer ErhardSteinhauer self-requested a review July 1, 2024 23:26
Copy link
Contributor

@ErhardSteinhauer ErhardSteinhauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotta merge master into this

Copy link
Contributor

@ErhardSteinhauer ErhardSteinhauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yolo

@ErhardSteinhauer ErhardSteinhauer merged commit 113ea92 into new-frontiers-14:master Jul 2, 2024
15 checks passed
FrontierATC added a commit that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants