Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Novalite C1, v2 #1265

Closed
wants to merge 11 commits into from
Closed

Conversation

mrscratch
Copy link
Contributor

@mrscratch mrscratch commented Apr 23, 2024

About the PR

This adds the SW LLC's "Novalite C1" semi-auto rifle to the game. The concept was originally tossed around as a more legal means for Mercenaries/Miners/etc to have a better Mid-Tier weapon to protect themselves with.

After the recent community/staff decision to firmly uphold the automatic weapons ban after the recent... space law headaches... I was inspired to actually setup this fork and attempt to make the rifle myself with a new "theme" in mind.

The gun:

closedbolt2
openbolt2
(updated openbolt sprite EDIT: updated again, used outdate sprite forgot sharkfin)

FINAL UPDATE (hopefully): improved on back and in hand sprites:

thegun

It is essentially what you would get if you applied some of the strictest gun law loophole aftermarket modifications to a Lecter. It's auto sear has been replaced with a semi-automatic sear, removing it's ability to be fired in full auto. It has a "Featureless Grip" or "Shark Fin" which is used to skirt around pistol grip laws. It has an internally locked magazine that is reloaded by using a Break-Action Receiver which allows you to quickly access the locked magazine. It comes with a SW LLC patented "High Capacity Assault Clip" which can attach or detach from the locked magazine to quickly load ammunition.

Why / Balance

Originally I just left it with the same stats as the Lecter except it is now Semi-Auto and has a 15 round "magazine". However to save future headaches I have lowered the rate of fire from 5 to 4. All Semi-Auto Pistols in the game currently have a firerate of 4-5 so for semi-automatic that seems to be the baseline.

How to test

Search Novalite in the entity spawner.
nova

Media

novalite_x264.mp4
  • I have added screenshots/videos to this PR showcasing its changes ingame.

Breaking changes

Changelog

Copy link
Contributor

github-actions bot commented Apr 23, 2024

RSI Diff Bot; head commit 0dfc32d merging into b3ccc2f
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Objects/Weapons/Guns/Ammunition/Magazine/Rifle/novalite_clip.rsi

State Old New Status
base Added
mag-1 Added
mag-10 Added
mag-11 Added
mag-12 Added
mag-13 Added
mag-14 Added
mag-15 Added
mag-2 Added
mag-3 Added
mag-4 Added
mag-5 Added
mag-6 Added
mag-7 Added
mag-8 Added
mag-9 Added

Resources/Textures/_NF/Objects/Weapons/Guns/Rifles/novalitec1.rsi

State Old New Status
base Added
bolt-open Added
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added
mag-0 Added

Edit: diff updated after 0dfc32d

@mrscratch
Copy link
Contributor Author

mrscratch commented Apr 23, 2024

Same as previous PR I closed, except this one should only interact with the _NF tags.yml instead. Everything else should be it's own yml. Oh and I updated the open bolt sprite so it more accurately reflects it's closed bolt state. Everything else is exactly the same.

EDIT: used older sprite when creating new branch, remade "featureless grip" aka "shark fin" pistol grip on the sprites. Looks much better.

@dvir001
Copy link
Contributor

dvir001 commented Apr 23, 2024

None of the guns or proto are under any _NF folders

@dvir001 dvir001 added S: Awaiting Changes This PR has changes that need to be made before merging S: DO NOT MERGE labels Apr 23, 2024
@mrscratch
Copy link
Contributor Author

I have no idea why _NF didn't click for me as New Frontier. It makes so much more sense now why the YML Warriors were telling me to put the tags in _NF/tags.yml

I've removed all the yml/sprites from the base ss14 section and relocated them into New Frontier's resource folder.

@mrscratch
Copy link
Contributor Author

Updated players "on back" and in hand sprites after seeing Quigley's clean burst rifle "on back" sprites. It should be much more apparent at first glance what a player is wielding when equipping this weapon.

@github-actions github-actions bot added the S: Merge Conflict This PR has conflicts that prevent merging label Apr 26, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict This PR has conflicts that prevent merging label Apr 26, 2024
@dvir001 dvir001 added S: Needs Review This PR is awaiting reviews and removed S: Awaiting Changes This PR has changes that need to be made before merging S: DO NOT MERGE labels Apr 26, 2024
Copy link
Member

@Cheackraze Cheackraze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, and gives regular civillians a class of this weapon that is more legal

@mrscratch
Copy link
Contributor Author

mrscratch commented Apr 28, 2024

It actually is a clip that attaches to the locked internal magazine. You can see the stripper clip in the video.

EDIT: Just found out from VividPups that it's actually called an "En bloc". I didn't know the meme concept was actually a real invention. Apparently they've been around since the late 1890's

@github-actions github-actions bot added the S: Merge Conflict This PR has conflicts that prevent merging label Apr 29, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict This PR has conflicts that prevent merging label Apr 30, 2024
@whatston3 whatston3 mentioned this pull request May 29, 2024
1 task
@dvir001
Copy link
Contributor

dvir001 commented Jun 1, 2024

Please update this PR with master and make sure its using the require 2 hands to use with new sprite.
Thanks

@github-actions github-actions bot added the S: Merge Conflict This PR has conflicts that prevent merging label Jun 1, 2024
Copy link
Contributor

github-actions bot commented Jun 1, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict This PR has conflicts that prevent merging label Jun 15, 2024
@ErhardSteinhauer
Copy link
Contributor

This rifle was introduced before wielding weapons become so common and as such now missing this feature and sprites.

Also if you need help with making this rifle obtainable in game from expeditions for example, I can assist you with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants