-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cyberpunk themed clothes and armor #1262
Cyberpunk themed clothes and armor #1262
Conversation
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
RSI Diff Bot; head commit f5d3e1a merging into 05d196b Resources/Textures/_NF/Clothing/Belt/punk.rsi
Resources/Textures/_NF/Clothing/Eyes/Glasses/punk_glasses.rsi
Resources/Textures/_NF/Clothing/Head/Hoods/Coat/acid_raincoat.rsi
Resources/Textures/_NF/Clothing/Head/Hoods/Coat/acid_raincoat_blue.rsi
Resources/Textures/_NF/Clothing/Head/Hoods/Coat/acid_raincoat_green.rsi
Resources/Textures/_NF/Clothing/Head/Hoods/Coat/acid_raincoat_magenta.rsi
Resources/Textures/_NF/Clothing/Head/Hoods/Coat/acid_raincoat_yellow.rsi
Resources/Textures/_NF/Clothing/Mask/punkhalfmask.rsi
Resources/Textures/_NF/Clothing/OuterClothing/Armor/bulletproof_vest_green.rsi
Resources/Textures/_NF/Clothing/OuterClothing/Armor/bulletproof_vest_orange.rsi
Resources/Textures/_NF/Clothing/OuterClothing/Armor/bulletproof_vest_procedural.rsi
Resources/Textures/_NF/Clothing/OuterClothing/Armor/bulletproof_vest_procedural_elite.rsi
Resources/Textures/_NF/Clothing/OuterClothing/Armor/bulletproof_vest_red.rsi
Resources/Textures/_NF/Clothing/OuterClothing/Coats/acid_raincoat.rsi
Resources/Textures/_NF/Clothing/OuterClothing/Coats/acid_raincoat_blue.rsi
Resources/Textures/_NF/Clothing/OuterClothing/Coats/acid_raincoat_green.rsi
Resources/Textures/_NF/Clothing/OuterClothing/Coats/acid_raincoat_magenta.rsi
Resources/Textures/_NF/Clothing/OuterClothing/Coats/acid_raincoat_yellow.rsi
Resources/Textures/_NF/Clothing/OuterClothing/Coats/blazer_jamrock.rsi
Resources/Textures/_NF/Clothing/OuterClothing/Coats/bomber_aerostatic.rsi
Resources/Textures/_NF/Clothing/OuterClothing/Coats/bomber_pinksleeves.rsi
Resources/Textures/_NF/Clothing/OuterClothing/Coats/bomber_punk_red.rsi
Resources/Textures/_NF/Clothing/OuterClothing/Coats/jacket_biker.rsi
Resources/Textures/_NF/Clothing/OuterClothing/Coats/jacket_leather.rsi
Resources/Textures/_NF/Clothing/OuterClothing/Coats/jacket_letterman_blue.rsi
Resources/Textures/_NF/Clothing/OuterClothing/Coats/jacket_letterman_brown.rsi
Resources/Textures/_NF/Clothing/OuterClothing/Coats/jacket_letterman_magenta.rsi
Resources/Textures/_NF/Clothing/OuterClothing/Coats/jacket_letterman_red.rsi
Resources/Textures/_NF/Clothing/OuterClothing/Coats/jacket_procedural.rsi
Resources/Textures/_NF/Clothing/Shoes/Boots/punk.rsi
Resources/Textures/_NF/Clothing/Uniforms/punk_procedural.rsi
Resources/Textures/_NF/Objects/Tools/umbrella.rsi
Resources/Textures/_NF/Structures/Holo/graffiti/highlighted.rsi
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
I'm digging the letterman jackets. Good stuff |
ngl, out of all things I've added in this PR so far, my personal fav is magenta letterman jacket |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…_punk.yml Co-authored-by: Whatstone <[email protected]>
…_punk.yml Co-authored-by: Whatstone <[email protected]>
…_punk.yml Co-authored-by: Whatstone <[email protected]>
…_punk.yml Co-authored-by: Whatstone <[email protected]>
…_punk.yml Co-authored-by: Whatstone <[email protected]>
…_punk.yml Co-authored-by: Whatstone <[email protected]>
It is, yeah. I probably can add generic icons for glasses/belt, but I don't think there is a way to sync colors between sprites. |
But I don't know really. The problem with generic icons in their current state that those wont represent how the item will look on the character, which imo when it comes to drip is more important than anything. |
Right, I got the idea: I can increase the scale of the icon sprite. That way it'll become more visible while retaining the colors. |
|
…nhauer/frontier-station-14 into 2024-04-03-Punk-Stuff
…nhauer/frontier-station-14 into 2024-04-03-Punk-Stuff
@whatston3 biggest thanks for proofreading, I appreciate that a lot |
Just as an idea, could the GenericVisualizer be used here? I know mail edits the layers based off of the state of a mail package, but I haven't played around with it. If you were to create a component with the colours/visible layers of your clothing and then pull that into the visualizer somehow, split it between the icon and sprite, that'd be neat. Not suggesting to put that in this PR, but it might be interesting. Retesting, thanks for the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few small suggestions (two descriptions and a possibly unintended change to factions), but this looks good, happy to approve once you take a look at those suggestions.
Tried to test the change to NavSmash for the hostile mob base, didn't really notice much smashing, though I was checking with punks - maybe if they had better weapons they'd be more inclined to smash things to come towards me - unsure.
Still excited to see these items used in-game. Hope the holograffiti's straightforward enough to remove.
Resources/Prototypes/_NF/Entities/Clothing/Eyes/punk_glasses.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/_NF/Entities/Clothing/Eyes/punk_glasses.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Whatstone <[email protected]>
Co-authored-by: Whatstone <[email protected]>
…nhauer/frontier-station-14 into 2024-04-03-Punk-Stuff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Faction changes seem good, liking the consistent order. Approving this, would like a second opinion given the amount of changes here.
About the PR
In draft until #1329 and #1338 merged
Things added:
Bundled changes:
To Do
Why / Balance
More drip
How to test
Spawn new items, wear.
Spawn graffiti holoprojector, apply it to various surfaces.
Media
Clothes and armor
Jackets
Armor and jumpsuits
Goggles, infoshades, halfmasks, webbings and boots
Graffiti
Breaking changes
none afaik
Known issues
Changelog
🆑 erhardsteinhauer