Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Randomized ATV sprite color, storage options for ATV/Bike, Hoverbike #1212

Merged

Conversation

ErhardSteinhauer
Copy link
Contributor

@ErhardSteinhauer ErhardSteinhauer commented Apr 11, 2024

About the PR

  • Split ATV sprite into hull and engine. Hull has randomized color on spawn.
  • Adds slot for a storage container (backpack, satchel, duffel, anything wieldable with storage component really) to ATV.
  • Adds satchel sized and shaped inventory grid to Skeleton Bike.
  • Adds void-capable hoverbike. Functions just like ATV, but can fly in space, buyable from cargo for 15k.
  • Additionally made variants for NFSD and mail carrier. Both variants instead of slot for duffel bag have satchel sized and shaped inventory grid. NFSD hoverbike has slot for stunbaton along with unique lights and honk sound, Mail Carrier has slot for RPDS.

Why / Balance

To facilitate planet looting by biker gangs.

Media (videos a a bit dated, screenshots are most recent)

2024-04-11.19-04-12.mp4
2024-04-21.19-07-32.mp4
2024-04-21.19-16-22.mp4

2024-4-23_16 58 06
2024-4-23_16 58 00

  • Added media showcase

Notes

Vehicles with storage options are frontier specific entities, changes made to base game files: limited to 4 lines in order to substitute base game ATV with Frontier ATV

Changelog
🆑 erhardsteinhauer

  • tweak: Added storage compartment to Skeleton Bike.
  • tweak: It is possible to strap a duffel bag to ATV now.
  • tweak: ATV hull color is now randomized.
  • add: Added void-capable hoverbike. Buy one at cargo today!
  • add: Added void-capable hoverbikes for NFSD and Mail Carrier.

@dvir001
Copy link
Contributor

dvir001 commented Apr 11, 2024

Have to ask, is the storage fucking with the click to ride, or the other way around?
Can you open the storage only from the verb menu?

@github-actions github-actions bot added the S: Needs Review This PR is awaiting reviews label Apr 11, 2024
@ErhardSteinhauer
Copy link
Contributor Author

ErhardSteinhauer commented Apr 11, 2024

Have to ask, is the storage fucking with the click to ride, or the other way around?
Can you open the storage only from the verb menu?

Click to ride has higher priority than opening storage, so if you want to open storage it's either through verb menu or through activate item in world button on your keyboard (I have it mapped to F but I'm not sure if it's default key bind).

@ErhardSteinhauer ErhardSteinhauer marked this pull request as draft April 11, 2024 15:45
Copy link
Contributor

github-actions bot commented Apr 11, 2024

RSI Diff Bot; head commit 8e0726e merging into 0a633a5
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Objects/Vehicles/atv.rsi

State Old New Status
bag Added
engine Added
hull Added
keys Added
lights Added
vehicle Added

Resources/Textures/_NF/Objects/Vehicles/hoverbike.rsi

State Old New Status
bag Added
engine Added
hull Added
keys Added
lights Added
mailgun Added
mailtrim Added
nfsdbaton Added
nfsdstar Added
vehicle Added

Edit: diff updated after 8e0726e

@ErhardSteinhauer ErhardSteinhauer marked this pull request as ready for review April 11, 2024 16:18
@ErhardSteinhauer ErhardSteinhauer changed the title Storage compartments for ATV/Bike Randomized ATV sprite, storage options for ATV/Bike Apr 11, 2024
@ErhardSteinhauer ErhardSteinhauer changed the title Randomized ATV sprite, storage options for ATV/Bike Randomized ATV sprite color, storage options for ATV/Bike Apr 11, 2024
Copy link
Contributor

@GreaseMonk GreaseMonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could revert buckleable.yml, make a new file in _NF folder containing the new version, and mark the old one abstract: true and update all references to VehicleATV and give the new atv a updated name.
This will make the old ATV not appear in spawn menu

Other than that i love the changes this makes ATV aspecially valuable to transport stuff

@ErhardSteinhauer
Copy link
Contributor Author

You could revert buckleable.yml, make a new file in _NF folder containing the new version, and mark the old one abstract: true and update all references to VehicleATV and give the new atv a updated name. This will make the old ATV not appear in spawn menu

Other than that i love the changes this makes ATV aspecially valuable to transport stuff

I thought about that. Right now this PR changes 2 existing files. If I'm to create Frontier specific ATV variant, I'm guessing I'll have to change more than 2 base game files to replace all the references to original so the new version would appear in the world instead. And I don't know which option is less problematic from maintainer point of view.

@ErhardSteinhauer
Copy link
Contributor Author

more than 2 base game files to replace all the references to original

Although I'm guessing it's just spawner and cargo crate fill.

@GreaseMonk
Copy link
Contributor

well if they change the ATV upstream, i'm going to have a harder time merging than if we had a NF variant , but the difference is effectively like 5 minutes time

@ErhardSteinhauer
Copy link
Contributor Author

Alright, I'll make the change then

@ErhardSteinhauer
Copy link
Contributor Author

ErhardSteinhauer commented Apr 12, 2024

You could revert buckleable.yml, make a new file in _NF folder containing the new version, and mark the old one abstract: true and update all references to VehicleATV and give the new atv a updated name. This will make the old ATV not appear in spawn menu

Other than that i love the changes this makes ATV aspecially valuable to transport stuff

Made those changes. Also added enduro motorcycle for the hell of it. Functions just like new ATV, stat-wise in between ATV and skeleton bike.

@ErhardSteinhauer ErhardSteinhauer changed the title Randomized ATV sprite color, storage options for ATV/Bike Randomized ATV sprite color, storage options for ATV/Bike, Hoverbike Apr 21, 2024
@ErhardSteinhauer
Copy link
Contributor Author

Added void-capable hoverbike.

@ErhardSteinhauer ErhardSteinhauer marked this pull request as draft April 21, 2024 18:24
@ErhardSteinhauer ErhardSteinhauer marked this pull request as ready for review April 21, 2024 20:44
@ErhardSteinhauer
Copy link
Contributor Author

I believe this PR is ready for review.

@github-actions github-actions bot added the S: Merge Conflict This PR has conflicts that prevent merging label Apr 23, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict This PR has conflicts that prevent merging label Apr 23, 2024
@ErhardSteinhauer
Copy link
Contributor Author

Huh, upstream resprited ATVs. Updated this PR accordingly.

@Cheackraze
Copy link
Member

sure these look great, thanks for the hard work on these

@Cheackraze Cheackraze merged commit 5dd1ff4 into new-frontiers-14:master Apr 26, 2024
14 checks passed
FrontierATC added a commit that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants