Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split cargo request console #1191

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Split cargo request console #1191

merged 2 commits into from
Apr 11, 2024

Conversation

GreaseMonk
Copy link
Contributor

@GreaseMonk GreaseMonk commented Apr 3, 2024

About the PR

  • Only orders made on the same computer will be shown now.
  • Only linked telepads will spawn goods

This allows for mappers to map more cargo request consoles on the same grid without consoles showing orders from other people, possibly mis-approving orders that arent theirs. Also, goods only spawn on linked telepads, so it wont end up elsewhere on station anymore.

image

This needs some degree of testing, ie. two players on same server order things and then check if the same data is showing

Technical details

Added net entity to the cargo order data, so any client can filter the orders accordingly

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

add: only show cargo orders from same console

@github-actions github-actions bot added the C# label Apr 3, 2024
@GreaseMonk GreaseMonk requested review from dvir001 and Cheackraze April 3, 2024 19:56
@github-actions github-actions bot added the S: Needs Review This PR is awaiting reviews label Apr 3, 2024
@GreaseMonk
Copy link
Contributor Author

GreaseMonk commented Apr 3, 2024

  • Needs some testing

@GreaseMonk GreaseMonk changed the title Only show orders made on same cargo console Cargo request console split Apr 3, 2024
@GreaseMonk GreaseMonk changed the title Cargo request console split Split cargo request console Apr 3, 2024
Copy link
Member

@Cheackraze Cheackraze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code all looks fine to me, a couple of .owner calls that are smelly but its from legacy code anyhow. I am unable to test at the moment, once this is tested in a multi-user environment it can get merged

@GreaseMonk
Copy link
Contributor Author

will test today or tomorrow with a friend

@GreaseMonk
Copy link
Contributor Author

this is good to go 👍🏼

@Cheackraze Cheackraze merged commit 2a5998b into master Apr 11, 2024
10 checks passed
@GreaseMonk GreaseMonk deleted the feature/split-orders branch April 11, 2024 19:58
Vonsant added a commit to Corvax-Frontier/corvax-frontier-14 that referenced this pull request Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# S: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants