Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change NFSD radio color #1187

Merged
merged 6 commits into from
Apr 8, 2024
Merged

Conversation

Leander-0
Copy link
Contributor

About the PR

Changes the NFSD color of the radio and organizes the new keys to be included on the new headsets when spawned as officer.

20240402-211625

Why / Balance

All needs to be recolored and they require their own sprites for their encryption keys.

Technical details

Changed the hotkey to use the radio from "S" to "G" to the original red security color and then the new NFSD radio color takes the "S" hotkey for radio also organized the files for more stuff to be on the _NF folders.

This PR will be a draft until the NFSD encryption keys are sprited.

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

🆑 Leander

  • add: NFSD got a new color on their radio with new frequency.

@dvir001
Copy link
Contributor

dvir001 commented Apr 3, 2024

This is a bit confusing, s is now NFSD?
This will confuse people coming from other forks with macule memory, best to keep nfsd as the new g.

@dvir001
Copy link
Contributor

dvir001 commented Apr 3, 2024

Also dont forget to make sure ghosts and admin ghosts can hear NFSD, we had this issue with the traffic channel when we just added it.
Also make sure the solar event can disable the NFSD channel

@dvir001
Copy link
Contributor

dvir001 commented Apr 3, 2024

Also make sure the channel is replaced for systems like the M_EMP and the security records and shipyard.

@dvir001
Copy link
Contributor

dvir001 commented Apr 3, 2024

Also make sure there isn't a way to get headsets with keys from any vender that spawn on expo or we going to have bad time again.

@Leander-0
Copy link
Contributor Author

This is a bit confusing, s is now NFSD? This will confuse people coming from other forks with macule memory, best to keep nfsd as the new g.

NFSD basically acts and its the security department here, it replaces the "S" because all players have here muscle memory about that and new players don't have to change muscle memory to "G" when playing NFSD for the first time.

'G' is for Station Guard and 'S' still for Security in NFSD.

@Leander-0
Copy link
Contributor Author

Also dont forget to make sure ghosts and admin ghosts can hear NFSD, we had this issue with the traffic channel when we just added it. Also make sure the solar event can disable the NFSD channel

Added the NFSD channel to the event, original Security one was not even there also for the MobObservers they have this already
20240403-071506

@dvir001
Copy link
Contributor

dvir001 commented Apr 3, 2024

This is a bit confusing, s is now NFSD? This will confuse people coming from other forks with macule memory, best to keep nfsd as the new g.

NFSD basically acts and its the security department here, it replaces the "S" because all players have here muscle memory about that and new players don't have to change muscle memory to "G" when playing NFSD for the first time.

'G' is for Station Guard and 'S' still for Security in NFSD.

This is confusing when you know that security exists and its now g.

@Leander-0
Copy link
Contributor Author

This is a bit confusing, s is now NFSD? This will confuse people coming from other forks with macule memory, best to keep nfsd as the new g.

NFSD basically acts and its the security department here, it replaces the "S" because all players have here muscle memory about that and new players don't have to change muscle memory to "G" when playing NFSD for the first time.
'G' is for Station Guard and 'S' still for Security in NFSD.

This is confusing when you know that security exists and its now g.

The security that "matters" and its most played by everyone its the NFSD, the old security channel with its new "g" key will just remain as something for someone else that wants to make any other small guard or events. its more easy to learn for a new player that the frontier security NFSD is S and not for the whole playerbase to learn that G is the new channel to constantly talk on radio and change muscle memory.

@Leander-0
Copy link
Contributor Author

Also make sure there isn't a way to get headsets with keys from any vender that spawn on expo or we going to have bad time again.

made a whole new encryption key and only added it to the Ptech vendor only available for the sheriff and SR and added a new box for so it can also be bought on the security uplink.

@github-actions github-actions bot added C# and removed No C# labels Apr 3, 2024
@Leander-0
Copy link
Contributor Author

Also make sure the channel is replaced for systems like the M_EMP and the security records and shipyard.

Should be addressed on latest commit.

@dvir001
Copy link
Contributor

dvir001 commented Apr 6, 2024

@Leander-0 Ok so after looking into this with Salvantrix the security channel should be renamed to "Guard" or something else to avoid it starting with S to be a bit less confusing the players seeing Security and assuming :s like every server.

Copy link
Contributor

github-actions bot commented Apr 7, 2024

RSI Diff Bot; head commit f5cae66 merging into 072a54d
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Objects/Devices/encryption_keys.rsi

State Old New Status
nfsd_label Added

Edit: diff updated after f5cae66

@Leander-0
Copy link
Contributor Author

@Leander-0 Ok so after looking into this with Salvantrix the security channel should be renamed to "Guard" or something else to avoid it starting with S to be a bit less confusing the players seeing Security and assuming :s like every server.

got it, should be solved on latest commit and the encryption key label was added so the PR is ready for review.

@Leander-0 Leander-0 marked this pull request as ready for review April 7, 2024 22:33
@dvir001 dvir001 requested review from dvir001 and Cheackraze April 7, 2024 22:33
@github-actions github-actions bot added the S: Needs Review This PR is awaiting reviews label Apr 7, 2024
@dvir001
Copy link
Contributor

dvir001 commented Apr 8, 2024

All seems fine but I didnt get around to test this in game, if someone gets to it and can confirm its all working this is good to go.

@Cheackraze Cheackraze merged commit 3172d56 into new-frontiers-14:master Apr 8, 2024
13 checks passed
FrontierATC added a commit that referenced this pull request Apr 8, 2024
@Leander-0 Leander-0 deleted the nfsd-headset branch June 14, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants