-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spawners #1173
Spawners #1173
Conversation
Here is the official Pr. things just keep breaking for me when trying to do stuff, So instead of adding the Bluespace Event with the spawners, Im just going to do Spawners first, then Mob spawners, then the Blue Space Event. to help prevent errors. |
As of now, these Commits should be restoring some of the weapons to its OG Files and the RSI back to its OG files. The only thing I haven't done as of now is the Mosin. I don't know why its like this but it is |
ALRIGHT, everything should return back to the Original state now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me but I want to defer to @MagnusCrowe and @Leander-0 for specific list balancing
Resources/Prototypes/_NF/Entities/Objects/Weapons/Guns/Guns/revolvers.yml
Outdated
Show resolved
Hide resolved
Will have a look in the next few days. |
@MagnusCrowe Please tell me the line its on if anything needs to be changed there is a lot of lines |
is there a reason why there is an Do not merge and need discussion on it? |
Right now im waiting for a maintainer to look at the spawner list, update it and approve when done. |
hello, its been about a week, I would like to request a review from yall if yall could |
Hey sorry about that, I'm looking at this now. |
Resources/Prototypes/_NF/Entities/Markers/Spawners/Random/event.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/_NF/Entities/Markers/Spawners/Random/event.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/_NF/Entities/Markers/Spawners/Random/event.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/_NF/Entities/Markers/Spawners/Random/event.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/_NF/Entities/Markers/Spawners/Random/event.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/_NF/Entities/Markers/Spawners/Random/event.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/_NF/Entities/Markers/Spawners/Random/event.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/_NF/Entities/Markers/Spawners/Random/event.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/_NF/Entities/Markers/Spawners/Random/event.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/_NF/Entities/Objects/Weapons/Ammunition/explosives.yml
Show resolved
Hide resolved
that moment when you did all the changes and yet... it didnt push right |
Alright, The first Set of Changes have been made. I believe I did everything, I might have miss things since. The one that had all of them got messed up. |
what is this post to be? |
Hi, I would like Request another review |
Due to the lack of communication and response. I'm just going to close this PR request |
About the PR
Single Item Loot spawners, Div talk about it before, There is currently a Thread also, However, Due to other PRs merging it is causing a lot of problems with my PRs So I decided to creat them 1 at a time. This being first
Why / Balance
Too add RnG to single loot instead of just Static and crates
Technical details
N/A
Media
N/A
Breaking changes
N/A
Changelog
Not really sure if this needs a change log for players. So will leave blank for now