Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spawners #1173

Closed
wants to merge 21 commits into from
Closed

Spawners #1173

wants to merge 21 commits into from

Conversation

VividPups
Copy link
Contributor

About the PR

Single Item Loot spawners, Div talk about it before, There is currently a Thread also, However, Due to other PRs merging it is causing a lot of problems with my PRs So I decided to creat them 1 at a time. This being first

Why / Balance

Too add RnG to single loot instead of just Static and crates

Technical details

N/A

Media

N/A

  • this PR does not require an ingame showcase

Breaking changes

N/A
Changelog
Not really sure if this needs a change log for players. So will leave blank for now

Copy link
Contributor

github-actions bot commented Mar 30, 2024

RSI Diff Bot; head commit c384b2b merging into 69a12c7
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:
Edit: diff updated after c384b2b

@VividPups
Copy link
Contributor Author

VividPups commented Mar 30, 2024

@dvir001 @MagnusCrowe

Here is the official Pr. things just keep breaking for me when trying to do stuff, So instead of adding the Bluespace Event with the spawners, Im just going to do Spawners first, then Mob spawners, then the Blue Space Event. to help prevent errors.
Atleast with this I could just make Quite chances to it... and please for the love of god if you are asking me to change something tell me the line it is on

@VividPups
Copy link
Contributor Author

VividPups commented Mar 30, 2024

As of now, these Commits should be restoring some of the weapons to its OG Files and the RSI back to its OG files. The only thing I haven't done as of now is the Mosin. I don't know why its like this but it is

@VividPups
Copy link
Contributor Author

ALRIGHT, everything should return back to the Original state now

Copy link
Member

@Cheackraze Cheackraze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me but I want to defer to @MagnusCrowe and @Leander-0 for specific list balancing

@MagnusCrowe
Copy link
Contributor

looks good to me but I want to defer to @MagnusCrowe and @Leander-0 for specific list balancing

Will have a look in the next few days.

@VividPups
Copy link
Contributor Author

@MagnusCrowe Please tell me the line its on if anything needs to be changed there is a lot of lines

@dvir001 dvir001 added S: Awaiting Changes This PR has changes that need to be made before merging S: DO NOT MERGE S: Needs Review This PR is awaiting reviews and removed S: Awaiting Changes This PR has changes that need to be made before merging labels Apr 8, 2024
@VividPups
Copy link
Contributor Author

is there a reason why there is an Do not merge and need discussion on it?

@dvir001
Copy link
Contributor

dvir001 commented Apr 8, 2024

DO NOT MERGE is added to mark a PR as needing changes and it cannot be added to the game without them.
Need Discussion is added to note it need the changes to be talked about.

Right now im waiting for a maintainer to look at the spawner list, update it and approve when done.

@VividPups
Copy link
Contributor Author

hello, its been about a week, I would like to request a review from yall if yall could

@MagnusCrowe
Copy link
Contributor

Hey sorry about that, I'm looking at this now.

@GreaseMonk GreaseMonk added S: Awaiting Changes This PR has changes that need to be made before merging and removed S: Needs Review This PR is awaiting reviews S: Need Discussion labels Apr 12, 2024
@VividPups
Copy link
Contributor Author

that moment when you did all the changes and yet... it didnt push right

@VividPups
Copy link
Contributor Author

Alright, The first Set of Changes have been made. I believe I did everything, I might have miss things since. The one that had all of them got messed up.

@VividPups
Copy link
Contributor Author

what is this post to be?

@VividPups VividPups requested a review from MagnusCrowe April 15, 2024 23:01
@github-actions github-actions bot added S: Needs Review This PR is awaiting reviews and removed S: Awaiting Changes This PR has changes that need to be made before merging labels Apr 15, 2024
@VividPups
Copy link
Contributor Author

Hi, I would like Request another review

@ThatOneGoblin25 ThatOneGoblin25 mentioned this pull request Apr 29, 2024
6 tasks
@VividPups VividPups requested a review from Cheackraze April 29, 2024 21:51
@VividPups VividPups closed this May 4, 2024
@VividPups VividPups deleted the Spawneres branch May 5, 2024 19:09
@VividPups
Copy link
Contributor Author

Due to the lack of communication and response. I'm just going to close this PR request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants