feat: add and remove schedule msgs can be modified in chain manager #ntrn-387 #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 28, 2024
NeverHappened
force-pushed
the
feat/chain-manager-cron-stargate
branch
from
94286af to
a6a80d4
Compare
swelf19
approved these changes
Sep 6, 2024
| } else if typed_proposal.type_field.as_str() == MSG_TYPE_REMOVE_SCHEDULE { | ||
| if strategy.has_cron_remove_schedule_permission() { | ||
| Ok(()) | ||
| } else { |
There was a problem hiding this comment.
LGTM. But i think it's possible to save a couple of lines of code. If you remove all 3
} else {
Err(ContractError::Unauthorized {})
}and just return the error Err(ContractError::Unauthorized {}) at the very end if non of if matches
pr0n00gler
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TASK
PR's: