-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable linting with ruff #60
Conversation
Hm, haven't managed to reproduce the failures locally neither with Python 3.12 or 3.13 with gcc or clang yet, so not quite sure what it doesn't like. The only "functional" changes in here should be moving from |
I re-ran the tests and it worked. This is a problem with tests using random numbers but no seeds, which is a bad idea for CI. For PyTest there is a module which does this very nicely, but I think for the current test structure, we need to set seeds manually. This definitely needs fixing, but it’s not related to this pull request. |
Yeah, agreed. I'll go ahead and make a little PR setting the seeds later today. Thanks for checking! |
Adds linting with ruff and fixes all the issues.
xref: neurophysik/CHSPy#8