Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Backport 8.2: Python 3.13 support #3319

Draft
wants to merge 20 commits into
base: release/8.2
Choose a base branch
from
Draft

Conversation

JCGoran
Copy link
Collaborator

@JCGoran JCGoran commented Jan 24, 2025

Uses #3317 as baseline. Also backported #3028, #3040, and part of #1969.

@JCGoran JCGoran added the release Release related issues label Jan 24, 2025
Comment on lines +55 to +59
39) numpy_ver="numpy>=2" ;;
310) numpy_ver="numpy>=2" ;;
311) numpy_ver="numpy>=2" ;;
312) numpy_ver="numpy>=2" ;;
313) numpy_ver="numpy>=2" ;;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because numpy 2 is backwards compatible, but numpy 1 is not forwards compatible, so building a wheel with numpy 1.x and testing it with 2.x will fail, but the other way around works.

@nrnhines
Copy link
Member

It looks like you're in some sense resurrecting my failed attempt (subsequently reverted) in #3317 to adopt master methods for ci into release/8.2. I'm speculating that my further attempts to manually and minimally just increase the list of pythons in release/8.2 is making good progress even though ci currently rests at 33 failing and 6 successful checks.
The main issues I'm dealing with now are forking coreneuron for release/8.2 into neuronsimulator and applying any needed version consistency updates. Also establishing that numpy and cython generated pyx files are compatible. I.e. by checking that the first line of the generated cpp file, if it exists, , e.g. /* Generated by Cython 3.0.11 */ matches the current cython version in use. (and re-generating if not). Anyway, when those two changes are accomplished, I'll see how the ci stands, and decide whether to continue that path.

Copy link

✔️ 8ad39c1 -> Azure artifacts URL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Release related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants