Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cvode no_cap uses direct backing store instead of Node* #3314

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

nrnhines
Copy link
Member

@nrnhines nrnhines commented Jan 21, 2025

This is the latest in a series of PR's and branches that are meant to improve cvode performance to the level of release/8.2
The series is
hines/cvlocal-bug #3299
hines/cell-contiguous #3300
hines/cellcontig+scatter-ptr https://github.com/neuronsimulator/nrn/tree/hines/cellcontig%2Bscatter-ptr
hines/cellcontig-scatter-treemat https://github.com/neuronsimulator/nrn/tree/hines/cellcontig-scatter-treemat
this PR

This PR generally approaches or exceeds the performance of 8.2 (at least for x86_64) with respect to cvode. Ringtest performance is (data copied from #3283 (comment))

nrniv -python ringtest.py -npt 1 -compart 1 3 -nring 32 -rparm -nt 1

x86_64 intel icx
version  fixed  global  local
8.2      1.86   30.5    1.35
master   1.53   56.0    6.67
contig   1.59   60.8    2.76
scatter  1.71   48.4    2.32
treemat  1.61   35.9    2.01
nocap    1.6    25.1    1.78

x86_64 gcc 13.3.0
version  fixed  global  local
8.2          2.92   51.9    2.47
master   2.38   63.4    6.19
contig    2.09   63.6    3.10
scatter   1.98   49.8    2.54
treemat  2.01   38.7    2.25
nocap     2.01   28.4    2.01

There continues to be an issue with Apple M1

Apple M1
version  fixed  global  local
8.2         1.87    23.67   1.32
master  4.1      60.1      5.3
contig    5.0      70.5      4.1
scatter   4.9      64.6      3.8
treemat 4.1      47.5      2.9
nocap    4.9      58.3      3.47
coreneuron 2.0

Copy link

✔️ 2123efe -> Azure artifacts URL

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 98.91697% with 3 lines in your changes missing coverage. Please review.

Project coverage is 67.12%. Comparing base (90900fa) to head (2123efe).

Files with missing lines Patch % Lines
src/nrncvode/netcvode.cpp 95.65% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3314      +/-   ##
==========================================
+ Coverage   67.08%   67.12%   +0.04%     
==========================================
  Files         571      571              
  Lines      111039   111086      +47     
==========================================
+ Hits        74485    74569      +84     
+ Misses      36554    36517      -37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant