-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cvode no_cap uses direct backing store instead of Node* #3314
base: master
Are you sure you want to change the base?
Conversation
…cellcontig+scatter-ptr
Quality Gate passedIssues Measures |
✔️ 2123efe -> Azure artifacts URL |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3314 +/- ##
==========================================
+ Coverage 67.08% 67.12% +0.04%
==========================================
Files 571 571
Lines 111039 111086 +47
==========================================
+ Hits 74485 74569 +84
+ Misses 36554 36517 -37 ☔ View full report in Codecov by Sentry. |
This is the latest in a series of PR's and branches that are meant to improve cvode performance to the level of release/8.2
The series is
hines/cvlocal-bug #3299
hines/cell-contiguous #3300
hines/cellcontig+scatter-ptr https://github.com/neuronsimulator/nrn/tree/hines/cellcontig%2Bscatter-ptr
hines/cellcontig-scatter-treemat https://github.com/neuronsimulator/nrn/tree/hines/cellcontig-scatter-treemat
this PR
This PR generally approaches or exceeds the performance of 8.2 (at least for x86_64) with respect to cvode. Ringtest performance is (data copied from #3283 (comment))
There continues to be an issue with Apple M1