Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate dynamic MPI headers out-of-source #3304

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

JCGoran
Copy link
Collaborator

@JCGoran JCGoran commented Jan 8, 2025

With this change, both src and share dirs no longer contain any build artifacts 🎉 (except *.egg-info, which is a bug in setuptools, see pypa/setuptools#1347, though I hope to replace setuptools with scikit-build-core at some point in the future).

Copy link

sonarqubecloud bot commented Jan 8, 2025

@JCGoran JCGoran marked this pull request as ready for review January 8, 2025 16:47
@JCGoran JCGoran added the building Issue related to build/compilation label Jan 8, 2025
Copy link

✔️ e4ec088 -> Azure artifacts URL

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.07%. Comparing base (9500741) to head (e4ec088).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3304   +/-   ##
=======================================
  Coverage   67.07%   67.07%           
=======================================
  Files         571      571           
  Lines      111055   111055           
=======================================
  Hits        74488    74488           
  Misses      36567    36567           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JCGoran JCGoran requested a review from nrnhines January 8, 2025 19:40
Copy link
Member

@nrnhines nrnhines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. I have no problem with merging as is. I notice that src/coreneuron/mpi did not have an issue with files generated in the source tree. Since that is mostly the same (derived from) as src/nrnmpi I suppose one of those will someday disappear. I have not investigated, but wonder how the coreneuron side handles the issue.

src/nrniv/CMakeLists.txt Show resolved Hide resolved
@JCGoran JCGoran merged commit 74dcdd5 into master Jan 10, 2025
41 checks passed
@JCGoran JCGoran deleted the jelic/build_mpi_out_of_source branch January 10, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building Issue related to build/compilation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants