Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datashuttle blog #98

Merged
merged 28 commits into from
May 7, 2024
Merged

Add datashuttle blog #98

merged 28 commits into from
May 7, 2024

Conversation

JoeZiminski
Copy link
Member

@JoeZiminski JoeZiminski commented Apr 29, 2024

This blog is the companion piece to #96. It's aims are to introduce datashuttle as a tool, giving an overview of the benefits of using it and its features.

@JoeZiminski JoeZiminski changed the base branch from main to add-neuroblueprint-blog April 29, 2024 17:53
@adamltyson
Copy link
Member

I think the only way around this is to use the light-mode for everything because it looks the least-worse.

Yeah I would just use the light mode image here. It looks nicer to have an image with a white background in dark mode, than an invisible image in lightmode. Also, I suspect most people will view the website in light mode? I use dark mode for most things, but not stuff like this.

Copy link
Member

@adamltyson adamltyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice @JoeZiminski, I've added a few comments.

docs/source/blog/datashuttle.md Outdated Show resolved Hide resolved
docs/source/blog/datashuttle.md Outdated Show resolved Hide resolved
docs/source/blog/datashuttle.md Outdated Show resolved Hide resolved
docs/source/blog/datashuttle.md Outdated Show resolved Hide resolved
docs/source/blog/datashuttle.md Outdated Show resolved Hide resolved
docs/source/blog/datashuttle.md Outdated Show resolved Hide resolved
docs/source/blog/datashuttle.md Outdated Show resolved Hide resolved
docs/source/blog/datashuttle.md Outdated Show resolved Hide resolved
docs/source/blog/datashuttle.md Show resolved Hide resolved
docs/source/blog/datashuttle.md Outdated Show resolved Hide resolved
Copy link
Member

@niksirbi niksirbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any way you can put your name first @JoeZiminski ? You did most of the work on datashuttle and on this blogpost.
i've left a few comments, mostly about phrasing.

docs/source/blog/datashuttle.md Outdated Show resolved Hide resolved
docs/source/blog/datashuttle.md Show resolved Hide resolved
docs/source/blog/datashuttle.md Show resolved Hide resolved
docs/source/blog/datashuttle.md Outdated Show resolved Hide resolved
docs/source/blog/datashuttle.md Show resolved Hide resolved
docs/source/blog/datashuttle.md Outdated Show resolved Hide resolved
docs/source/blog/datashuttle.md Outdated Show resolved Hide resolved
docs/source/blog/datashuttle.md Outdated Show resolved Hide resolved
docs/source/blog/datashuttle.md Outdated Show resolved Hide resolved
docs/source/blog/datashuttle.md Outdated Show resolved Hide resolved
@JoeZiminski JoeZiminski marked this pull request as ready for review May 1, 2024 17:26
Base automatically changed from add-neuroblueprint-blog to main May 2, 2024 15:35
@JoeZiminski JoeZiminski force-pushed the add-datashuttle-blog branch from a265ad9 to bd322e5 Compare May 3, 2024 21:43
@JoeZiminski
Copy link
Member Author

Hey finished with some final tidy ups and tweaks. Could tweak it forever! Would be great if someone can have a final read-through then happy for it to be merged next week.

@JoeZiminski JoeZiminski requested review from niksirbi and adamltyson May 3, 2024 21:45
docs/source/blog/datashuttle.md Outdated Show resolved Hide resolved
docs/source/blog/datashuttle.md Outdated Show resolved Hide resolved
docs/source/blog/datashuttle.md Outdated Show resolved Hide resolved
docs/source/blog/datashuttle.md Outdated Show resolved Hide resolved
docs/source/blog/datashuttle.md Show resolved Hide resolved
docs/source/blog/datashuttle.md Outdated Show resolved Hide resolved
Comment on lines 144 to 145
There are a number of shortcuts to ensure only
information relevant to your specific project must be typed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what this sentence means. Should it read "only be typed" at the end?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also coudn't parse this sentence. I'll rewrite it as:
"There are a number of shortcuts to reduce the amount of manual typing."

docs/source/blog/datashuttle.md Outdated Show resolved Hide resolved
docs/source/blog/datashuttle.md Outdated Show resolved Hide resolved
docs/source/blog/datashuttle.md Outdated Show resolved Hide resolved
@niksirbi
Copy link
Member

niksirbi commented May 7, 2024

Hey @adamltyson, I did a final pass on this post, caught a few more typos and formatting errors, and very slightly rephrased some sentences (ensuring, for example, that data are consistently plural).

I also cross-linked the two blogposts in their introductions. I'm merging this now and we can start sharing the blog posts tomorrow.

@niksirbi niksirbi merged commit d54ddd6 into main May 7, 2024
3 checks passed
@niksirbi niksirbi deleted the add-datashuttle-blog branch May 7, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants