Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new project types #70

Merged
merged 17 commits into from
Oct 24, 2023
Merged

Add new project types #70

merged 17 commits into from
Oct 24, 2023

Conversation

adamltyson
Copy link
Member

@adamltyson adamltyson commented Oct 19, 2023

Closes #74
Closes #73
Closes #56
Closes #55
Closes #69

@adamltyson adamltyson requested a review from a team October 19, 2023 08:09
JoeZiminski and others added 3 commits October 20, 2023 15:15
Please review, I think this is okay maybe I can run it by Pierre.
@adamltyson
Copy link
Member Author

For reference, here are the remaining tasks as agreed last week:
#56
#69
#73
#74
#75

cc @niksirbi @JoeZiminski

@niksirbi
Copy link
Member

Hey @adamltyson, I'll work on finalising the card images today and on updating the behaviour info.

@niksirbi
Copy link
Member

I designed the missing images for the cards and made sure that they are all of uniform size and style.
This is how they look now (feedback is welcome):

Screenshot 2023-10-23 at 14 49 59

@adamltyson
Copy link
Member Author

I designed the missing images for the cards and made sure that they are all of uniform size and style. This is how they look now (feedback is welcome):

Screenshot 2023-10-23 at 14 49 59

This is fantastic @niksirbi.

@JoeZiminski
Copy link
Member

JoeZiminski commented Oct 23, 2023

awesome @niksirbi !!

@niksirbi
Copy link
Member

awesome @niksirbi !!

The ephys traces were simulated in Python as Poisson spike trains + some gaussian noise. I didn't bother to model refractory periods though 🤫

@adamltyson adamltyson marked this pull request as ready for review October 24, 2023 06:41
@adamltyson
Copy link
Member Author

I think this can be merged now. I've removed the collaborations section for now, and opened #76 to track adding this.

The various pages now are fairly inhomogeneous, so I think we just need #75 to be addressed, then it's good to go for now.

@adamltyson adamltyson requested a review from a team October 24, 2023 09:52
Copy link
Member

@IgorTatarnikov IgorTatarnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

My only comment was about the consistency of links on each project page. The old project pages had green links underneath while the new ones don't. However, I see that it's going to be resolved by #80.

@adamltyson adamltyson merged commit 2aaec92 into main Oct 24, 2023
@adamltyson adamltyson deleted the new-material branch October 24, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants