Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RoI Interactions with Points #395

Closed
wants to merge 29 commits into from

Conversation

willGraham01
Copy link
Contributor

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

What does this PR do?

References

Please reference any existing issues/PRs that relate to this PR.

How has this PR been tested?

Please explain how any new code has been tested, and how you have ensured that no existing functionality has changed.

Is this a breaking change?

If this PR breaks any existing functionality, please explain how and why.

Does this PR require an update to the documentation?

If any features have changed, or have been added. Please explain how the
documentation has been updated.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 88.51351% with 17 lines in your changes missing coverage. Please review.

Project coverage is 98.41%. Comparing base (84b245c) to head (114cffe).
Report is 21 commits behind head on wgraham-roi-playground.

Files with missing lines Patch % Lines
movement/roi/base.py 78.75% 17 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           wgraham-roi-playground     #395      +/-   ##
==========================================================
- Coverage                   99.80%   98.41%   -1.40%     
==========================================================
  Files                          15       19       +4     
  Lines                        1048     1196     +148     
==========================================================
+ Hits                         1046     1177     +131     
- Misses                          2       19      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willGraham01 willGraham01 force-pushed the wgraham-roi-playground branch from 92ba767 to 3a7d56d Compare January 31, 2025 09:02
@willGraham01 willGraham01 force-pushed the wgraham-roi-point-to-line branch from e1b1c36 to 114cffe Compare January 31, 2025 09:53
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@willGraham01
Copy link
Contributor Author

Going to close this pending reorganisation of #390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant