-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor auto-generate API docs #331
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #331 +/- ##
=======================================
Coverage 99.76% 99.76%
=======================================
Files 14 14
Lines 846 846
=======================================
Hits 844 844
Misses 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @lochhh!
Just two questions for you:
- Do the changes in
make.bat
also enable a simpler syntax for building the docs on Windows? If yes, the contributing guide should be updated accordingly. - should we constrain
sphinx>=8.1
in the docs requirements?
Thanks for spotting this. That's done. Feel free to suggest better names than "
I've removed the constraint completely. |
Quality Gate passedIssues Measures |
This looks good now @lochhh, shall we merge it? |
Done. Thanks for taking a final look! |
Description
What is this PR
Why is this PR needed?
closes #329
What does this PR do?
This PR
clean
action and enables the fail-on-warnings mode for Sphinx (-W
) in the Windows make.bat to match the Unix Makefile--keep-going
for Sphinx (as it is automatically enabled from Sphinx 8.1)requirements.txt
References
#329
How has this PR been tested?
Local docs build
Checklist: