Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIA tracks data loader #186

Closed
wants to merge 14 commits into from
Closed

VIA tracks data loader #186

wants to merge 14 commits into from

Conversation

sfmig
Copy link
Contributor

@sfmig sfmig commented May 23, 2024

Before submitting a pull request (PR), please read the contributing guide.

Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

What does this PR do?

References

#167

How has this PR been tested?

Please explain how any new code has been tested, and how you have ensured that no existing functionality has changed.

Is this a breaking change?

If this PR breaks any existing functionality, please explain how and why.

Does this PR require an update to the documentation?

If any features have changed, or have been added. Please explain how the
documentation has been updated.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 18.69919% with 100 lines in your changes missing coverage. Please review.

Project coverage is 86.64%. Comparing base (e4eea35) to head (631f019).

Files Patch % Lines
movement/io/load_bboxes.py 0.00% 79 Missing ⚠️
movement/validators/datasets.py 50.00% 16 Missing ⚠️
movement/validators/files.py 50.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #186       +/-   ##
===========================================
- Coverage   99.68%   86.64%   -13.04%     
===========================================
  Files          12       13        +1     
  Lines         643      764      +121     
===========================================
+ Hits          641      662       +21     
- Misses          2      102      +100     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfmig sfmig force-pushed the smg/add-via-dataloader branch from 25b215b to 946daee Compare May 28, 2024 10:46
@sfmig sfmig mentioned this pull request Jun 3, 2024
6 tasks
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@sfmig
Copy link
Contributor Author

sfmig commented Jun 20, 2024

superseded by #229

@sfmig sfmig closed this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant