-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding CIFAR-10 DQN experiment #525
Adding CIFAR-10 DQN experiment #525
Conversation
- This commit adds a deep Q-learning experiment notebook on the task of image classification using CIFAR-10 dataset.
Codecov Report
@@ Coverage Diff @@
## staging #525 +/- ##
========================================
Coverage 90.09% 90.09%
========================================
Files 7 7
Lines 404 404
========================================
Hits 364 364
Misses 40 40 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are mixing keras
and tensorflow.keras
here. The later one should be always used. Also, please rename notebook to cifar_q_learning
.
Change the name of the file / tensorflow.keras as requested
Fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not completely I think. You don't need to install keras from GitHub anymore right?
I don't think I have installed keras package in the notebook. Are you referring to the keras-rl2 package? That is an independent package for deep reinforcement learning algorithms. I am attaching the link here. (https://github.com/taylormcnally/keras-rl2) You can also refer to Sarah's PR since we are using the same imported packages. |
@mordred-skywalker cool! Thanks for pointing that out. They use |
|
Sure! please let me know if other changes are required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of imported packages are not used. You can remove them and make the import code block shorter. Other than that LGTM.
Remove unused packages from the import block.
Hmmm, it seems that you also need to work on GitHub skills as well, so that you don't delete & re-upload files each time, resulting in unnecessary commits. Try watching some video tutorials on how to commit & push your changes with GitHub Desktop or command line. |
Yes, I am relatively new to Github but I'll look into that :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still unnecessary imports like pandas
, random
, & shuffle
. Look through each line and just search in your file. If you did not use it, discard it.
You have been using it for a semester. Better make improvements before the next~ |
Deleted them in the new commit. |
Reference issue
Contributes experiment related to #289
Type of change
Documentation - added experiment
What does this implement/fix?
This PR adds a Deep Q-learning experiment notebook on the task of image classification using CIFAR-10 dataset.
Additional information