-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patrick map #22
base: main
Are you sure you want to change the base?
Patrick map #22
Conversation
Integrated Here Android SDK Initialized Here SDK Added MapView Load Map Scene
Co-authored-by: patrickraullang <[email protected]>
Co-authored-by: patrickraullang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the desired features. Should be ready for further testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First wave: code style review
app/html/index.js
Outdated
// Enable the event system on the map instance: | ||
var mapEvents = new H.mapevents.MapEvents(map); | ||
|
||
// Add event listener: | ||
map.addEventListener("tap", function (evt) { | ||
// Log 'tap' and 'mouse' events: | ||
console.log(evt.type, evt.currentPointer.type); | ||
}); | ||
|
||
// Instantiate the default behavior, providing the mapEvents object: | ||
var behavior = new H.mapevents.Behavior(mapEvents); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linting errors because var behavior
not used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you use let
or const
instead of var
?
No description provided.