Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patrick map #22

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Patrick map #22

wants to merge 13 commits into from

Conversation

patrickraullang
Copy link

No description provided.

Integrated Here Android SDK
Initialized Here SDK
Added MapView
Load Map Scene
@mayfinn mayfinn changed the base branch from main to m-feat-routenbegleitung August 1, 2023 07:31
mayfinn and others added 2 commits August 2, 2023 14:50
Base automatically changed from m-feat-routenbegleitung to 3-design-spezifikation-in-mobile-app-umgesetzt August 6, 2023 20:53
Base automatically changed from 3-design-spezifikation-in-mobile-app-umgesetzt to main August 8, 2023 13:22
Copy link
Author

@patrickraullang patrickraullang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the desired features. Should be ready for further testing.

Copy link
Member

@mayfinn mayfinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First wave: code style review

Comment on lines 32 to 42
// Enable the event system on the map instance:
var mapEvents = new H.mapevents.MapEvents(map);

// Add event listener:
map.addEventListener("tap", function (evt) {
// Log 'tap' and 'mouse' events:
console.log(evt.type, evt.currentPointer.type);
});

// Instantiate the default behavior, providing the mapEvents object:
var behavior = new H.mapevents.Behavior(mapEvents);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linting errors because var behavior not used

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you use let or const instead of var?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants