Remove $useTimeZoneWithRRules class attribute

The reasoning behind why this exists does not appear to be explained anywhere. Besides, I don't think it's needed. It's certainly not tested to make sure it works as intended.
nettstudio · Jul 31, 2019 · b2a6c01 · b2a6c01
1 parent 4ce486c
commit b2a6c01
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 98 deletions.
diff --git a/README.md b/README.md
@@ -134,7 +134,6 @@ need to be evaluated before non-fitting events can be dropped.
 | `$shouldFilterByWindow`        | :heavy_multiplication_x: | `false`                                                                                           | `true` if either `$filterDaysBefore` or `$filterDaysAfter` are set                                                                                                                                                                                                                                                                                                                                                                                                                            |
 | `$skipRecurrence`              | :ballot_box_with_check:  | `false`                                                                                           | Toggles whether to skip the parsing of recurrence rules                                                                                                                                                                                                                                                                                                                                                                                                                                       |
 | `$todoCount`                   | :heavy_multiplication_x: | N/A                                                                                               | Tracks the number of todos in the current iCal feed                                                                                                                                                                                                                                                                                                                                                                                                                                           |
-| `$useTimeZoneWithRRules`       | :ballot_box_with_check:  | `false`                                                                                           | Toggles whether to use time zone info when parsing recurrence rules                                                                                                                                                                                                                                                                                                                                                                                                                           |
 | `$windowMaxTimestamp`          | :heavy_multiplication_x: | `null`                                                                                            | If `$filterDaysBefore` or `$filterDaysAfter` are set then the events are filtered according to the window defined by this field and `$windowMinTimestamp`                                                                                                                                                                                                                                                                                                                                     |
 | `$windowMinTimestamp`          | :heavy_multiplication_x: | `null`                                                                                            | If `$filterDaysBefore` or `$filterDaysAfter` are set then the events are filtered according to the window defined by this field and `$windowMaxTimestamp`                                                                                                                                                                                                                                                                                                                                     |
 
@@ -163,7 +162,7 @@ need to be evaluated before non-fitting events can be dropped.
 | `iCalDateToUnixTimestamp`                       | `$icalDate`                                                         | `public`    | Returns a Unix timestamp from an iCal date time format                                                                                              |
 | `iCalDateWithTimeZone`                          | `$event`, `$key`, `$format = DATE_TIME_FORMAT`                      | `public`    | Returns a date adapted to the calendar time zone depending on the event `TZID`                                                                      |
 | `doesEventStartOutsideWindow`                   | `$event`                                                            | `protected` | Determines whether the event start date is outside `$windowMinTimestamp` / `$windowMaxTimestamp`                                                    |
-| `isExdateMatch`                                 | `$exdate`, `$anEvent`, `$recurringOffset`                           | `protected` | Checks if an excluded date matches a given date by reconciling time zones                                                                           |
+| `isExdateMatch`                                 | `$exdate`, `$anEvent`                                               | `protected` | Checks if an excluded date matches a given date by reconciling time zones                                                                           |
 | `isFileOrUrl`                                   | `$filename`                                                         | `protected` | Checks if a filename exists as a file or URL                                                                                                        |
 | `isOutOfRange`                                  | `$calendarDate`, `$minTimestamp`, `$maxTimestamp`                   | `protected` | Determines whether a valid iCalendar date is within a given range                                                                                   |
 | `isValidCldrTimeZoneId`                         | `$timeZone`                                                         | `protected` | Checks if a time zone is a valid CLDR time zone                                                                                                     |

diff --git a/examples/index.php b/examples/index.php
@@ -14,7 +14,6 @@
         'filterDaysAfter'             => null,  // Default value
         'filterDaysBefore'            => null,  // Default value
         'skipRecurrence'              => false, // Default value
-        'useTimeZoneWithRRules'       => false, // Default value
     ));
     // $ical->initFile('ICal.ics');
     // $ical->initUrl('https://raw.githubusercontent.com/u01jmg3/ics-parser/master/examples/ICal.ics', $username = null, $password = null, $userAgent = null);