fix(deps): remove unintentional user dependency on deno
#452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We accidentally introduced a dependency on deno at site build time by including a command that uses `deno` in a post-install hook. The intent was to run it before typechecking, so including it in the build command is fine and won't run for users.
✅ Deploy Preview for remix-serverless ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for remix-edge ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pieh
approved these changes
Sep 9, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We accidentally introduced a dependency on
denoat site build time by including a command that usesdenoin a post-install hook.The intent was to run it before typechecking and before publishing, so including it in the build command instead works as well but won't run for users.
Related Tickets & Documents
N/A
QA Instructions, Screenshots, Recordings
Delete
packages/remix-edge-adapter/{dist,deno.d.ts}, runpnpm run build:packages, inspect output, runpnpm run typecheck. All looks good.