Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: upgrade to ipx 2 #218

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat!: upgrade to ipx 2 #218

wants to merge 2 commits into from

Conversation

ascorbic
Copy link

@ascorbic ascorbic commented Oct 30, 2023

Upgrade to ipx 2. Is a breaking change because it requires Node 18.

@github-actions github-actions bot added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Oct 30, 2023
@ascorbic ascorbic changed the title feat: upgrade to ipx 2 feat!: upgrade to ipx 2 Oct 30, 2023
@ascorbic ascorbic marked this pull request as ready for review October 30, 2023 20:00
@ascorbic ascorbic requested a review from a team as a code owner October 30, 2023 20:00
Comment on lines +19 to +21
"engines": {
"node": ">=18.0.0"
},
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ipx 2 uses H3, which uses global fetch objects. Rather than polyfilling it seems to make sense to just set the ngines requirement, as both Next and Gatsby now require it too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant