Make all data providers return iterable

netgen-layouts · Nov 13, 2023 · 43b782e · 43b782e
1 parent b3c0de6
commit 43b782e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 10 deletions.
diff --git a/phpstan.tests.neon b/phpstan.tests.neon
@@ -12,3 +12,7 @@ parameters:
         -
             message: '#RepositoryInterface (but )?does not specify its types#'
             path: tests/lib/Validator/RepositoryValidatorFactory.php
+
+        # Disable errors about missing value types in PHPUnit data providers
+
+        - '#Method .+Test::\w+DataProvider\(\) return type has no value type specified in iterable type iterable.#'
diff --git a/tests/lib/Parameters/ParameterType/SectionTypeTest.php b/tests/lib/Parameters/ParameterType/SectionTypeTest.php
@@ -60,10 +60,8 @@ public function testInvalidOptions(array $options): void
 
     /**
      * Provider for testing valid parameter attributes.
-     *
-     * @return mixed[]
      */
-    public static function validOptionsDataProvider(): array
+    public static function validOptionsDataProvider(): iterable
     {
         return [
             [
@@ -75,10 +73,8 @@ public static function validOptionsDataProvider(): array
 
     /**
      * Provider for testing invalid parameter attributes.
-     *
-     * @return mixed[]
      */
-    public static function invalidOptionsDataProvider(): array
+    public static function invalidOptionsDataProvider(): iterable
     {
         return [
             [
@@ -144,10 +140,7 @@ public function testIsValueEmpty(mixed $value, bool $isEmpty): void
         self::assertSame($isEmpty, $this->type->isValueEmpty(new ParameterDefinition(), $value));
     }
 
-    /**
-     * @return mixed[]
-     */
-    public static function emptyDataProvider(): array
+    public static function emptyDataProvider(): iterable
     {
         return [
             [null, true],