Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): resolve :param retrieval in prefix in middleware #13886

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
+225 −32
Open

fix(core): resolve :param retrieval in prefix in middleware #13886

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
79ee021
fix: resolve middlewares not executed when root path is excluded
CodyTseng Aug 14, 2024
ffa4f65
fix: `extractPathsForm` result when there are multiple `versionPaths`
CodyTseng Aug 14, 2024
efb30c1
test: add test case for middleware param retrieval
CodyTseng Aug 14, 2024
9552386
Merge branch 'master' into fix-middleware
CodyTseng Aug 14, 2024
526c4d9
refactor: improve readability of `extractPathsFrom` method
CodyTseng Aug 15, 2024
683ef1f
feat: special extract paths logic only when prefix contains `:param`
CodyTseng Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: add test case for middleware param retrieval
@CodyTseng
CodyTseng committed Aug 14, 2024
commit efb30c1d6707a8d0564dc2dd3ed4cb85f5a7abb0
11 changes: 11 additions & 0 deletions integration/nest-application/global-prefix/e2e/global-prefix.spec.ts
View file
Original file line number Diff line number Diff line change
@@ -130,6 +130,17 @@ describe('Global prefix', () => {
.expect(200, { '0': 'params', tenantId: 'test' });
});

it(`should get the params in the global prefix with exclude option`, async () => {
app.setGlobalPrefix('/api/:tenantId', { exclude: ['/'] });

server = app.getHttpServer();
await app.init();

await request(server)
.get('/api/test/params')
.expect(200, { '0': 'params', tenantId: 'test' });
});

it(`should execute middleware only once`, async () => {
app.setGlobalPrefix('/api', { exclude: ['/'] });