-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feature) : Added a new sample project for GraphQL schema first testing #12281
base: master
Are you sure you want to change the base?
(feature) : Added a new sample project for GraphQL schema first testing #12281
Conversation
Pull Request Test Coverage Report for Build 8f722235-919f-4c28-bb43-b40f2024ee87
💛 - Coveralls |
Could we update one of the existing projects instead of adding yet another example? |
However you feel comfortable. Please let me know your thoughts on it
What would you prefer to do?
…On Mon, Aug 28, 2023, 1:19 PM Kamil Mysliwiec ***@***.***> wrote:
Could we update one of the existing projects instead of adding yet another
example?
—
Reply to this email directly, view it on GitHub
<#12281 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD77J2RQPDX7R3MUWVGR2OTXXRIALANCNFSM6AAAAAA36E5Z4E>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
If we could add tests to this https://github.com/nestjs/nest/tree/master/sample/12-graphql-schema-first sample instead, that would be easier to maintain down the road (we already have plenty of samples in this repository) |
Thanks, I will do it One more thing, Can I also write the documentation about Testing in GraphQL and Nest.js? My idea is to write the documentation of my sample project into official Nest.js docs What do you suggest? |
Hey @kamilmysliwiec |
I have created a simple SyntaxError: /project/home/haidermalik12/workspace/src/cats/cats.service.spec.ts: Missing semicolon. (6:13)
4 |
5 | describe('CatsService', () => {
> 6 | let service: CatsService;
| ^
7 |
8 | beforeEach(async () => {
9 | const module: TestingModule = await Test.createTestingModule({
@kamilmysliwiec Could you help? Here is my source code: Github Repo |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
I have added a new sample project on Graphql testing with the schema first approach.
Does this PR introduce a breaking change?
Other information