Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid send broadcast message when shutdown private channel #433

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Avoid send broadcast message when shutdown private channel #433

merged 1 commit into from
Jan 2, 2025

Conversation

chenyukang
Copy link
Collaborator

Fixes #431
unresolved issue: #431 (comment)

@contrun
Copy link
Collaborator

contrun commented Jan 2, 2025 •
edited
Loading

You can cherry pick the commit b64a3a2 in #435 to solve the problem of the program not exiting even if the actor panicked. That PR can be closed after the cherry-picking.

@quake quake merged commit 84a1940 into nervosnetwork:develop Jan 2, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@contrun contrun contrun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[open_channel] shut_down private channel will cause panic public channel can generate channel update message
3 participants
@chenyukang @contrun @quake