Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom hop hints and fix self payment #432

Merged
merged 22 commits into from
Jan 3, 2025
Merged

Add custom hop hints and fix self payment #432

merged 22 commits into from
Jan 3, 2025
+1,461 −493

Conversation

chenyukang
Copy link
Collaborator

@chenyukang chenyukang commented Jan 2, 2025 •
edited
Loading

  1. Move add_tlc, remove_tlc, commitment_signed to dev RPC module, fixes Cleanup channel RPC #366
  2. Add hop hints for routing algorithm
  3. Use hop hint for self payment to handle more complex scenario, add test case for self pay, fixes self-payment fails when both channels have zero remote_balance #355

quake
quake requested changes Jan 2, 2025
View reviewed changes
src/fiber/graph.rs Outdated Show resolved Hide resolved
src/rpc/README.md Show resolved Hide resolved
src/fiber/graph.rs Outdated Show resolved Hide resolved
quake
quake reviewed Jan 2, 2025
View reviewed changes
src/fiber/graph.rs Outdated Show resolved Hide resolved
quake
quake approved these changes Jan 3, 2025
View reviewed changes
src/fiber/graph.rs Outdated Show resolved Hide resolved
@quake quake merged commit eb99b37 into nervosnetwork:develop Jan 3, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake quake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup channel RPC self-payment fails when both channels have zero remote_balance
2 participants
@chenyukang @quake