fix(gh_actions_ls): Fix incorrect rootdir resolution

[Crashdummyy]

Regression of #3566

[Crashdummyy]

@justinmk
Sorry I made a big mistake in the function could you please have a look at this ?
Sorry for the trouble

[glepnir]

use vim.fs.dirname

[Crashdummyy]

Like this ?

diff --git a/lua/lspconfig/configs/gh_actions_ls.lua b/lua/lspconfig/configs/gh_actions_ls.lua
index 9ea39b85..ebd48f60 100644
--- a/lua/lspconfig/configs/gh_actions_ls.lua
+++ b/lua/lspconfig/configs/gh_actions_ls.lua
@@ -15,7 +15,8 @@ return {
 
       for _, entry in ipairs(patterns) do
         if filename:find(entry.pattern) then
-          local match = vim.fs.find(entry.root, { path = filename, upward = true })[1]
+          local dir = vim.fs.dirname(filename)
+          local match = vim.fs.find(entry.root, { path = dir, upward = true })[1]
           if match then
             return match
           end

What do you want me to replace ?

EDIT:
Or dont you like any filename: ?
I could o something like this

      local dirs_to_check = {
        '.github/workflows',
        '.forgejo/workflows',
        '.gitea/workflows',
      }
      local dir = vim.fs.dirname(filename)
      for _, subdir in ipairs(dirs_to_check) do
        local match = vim.fs.find(subdir, { path = dir, upward = true })[1]
        if match and vim.fn.isdirectory(match) == 1 and vim.fs.dirname(filename) == match then
            return match
        end
      end

[dundargoc]

What exactly is the regression? When I test out gh_actions on master it seems to work for me.

[Crashdummyy]

What exactly is the regression? When I test out gh_actions on master it seems to work for me.

oh really ?
In my case it doesnt load at all.

this branch:

master:

Maybe due t nvim 0.11 or something like that I dont know.
This solution at least works accross all devices and combinations I tested

[dundargoc]

What repo/file are you testing? I'd like to test it.

[Crashdummyy]

What repo/file are you testing? I'd like to test it.

Take that one for instance

https://github.com/Crashdummyy/roslynLanguageServer.git

I cant open nvim .github/workflows/cleanup.yml

with this change

[dundargoc]

OK, you're right, I can recreate the problem. Thanks. Let me take a look at the code.

[dundargoc]

Does the following work? I tried it and autocompletion worked for me

 root_dir = require('lspconfig.util').root_pattern('.github/workflows', '.forgejo/workflows', '.gitea/workflows'),

[Crashdummyy]

Does the following work? I tried it and autocompletion worked for me

 root_dir = require('lspconfig.util').root_pattern('.github/workflows', '.forgejo/workflows', '.gitea/workflows'),

Tested that one as well.
First of all I thought I should not use root_pattern anymore.
Besides it only detects the existence of .github/workflows.

When I open any other random file it tries to attach as well.

EDIT:

# should be detected
.
├──.github
│    └── workflows
│     ├── CreateSnapshot.yml
│     ├── dotnet.yml
│     ├── loadtests.yml
│     ├── release.yml
│     ├── RestoreSnapshot.yml
│     └── tenantconfigs
│     └── action.yml
│
├── cmiLoadTestSchema.yml # should not be detected

[dundargoc]

First of all I thought I should not use root_pattern anymore.

Yes, but then I said in #3573 (comment) that because of reasons we can still use root_pattern. The current approach of vim.fs.dirname(... is also fine.

[Crashdummyy]

First of all I thought I should not use root_pattern anymore.

Yes, but then I said in #3573 (comment) that because of reasons we can still use root_pattern. The current approach of vim.fs.dirname(... is also fine.

Oh sorry I misread that.
It felt more like I am still allowed to use it but should prefer to avoid it.

[dundargoc]

OK, this works for me. There might be an easier way to achieve this but eh