-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: let core handle 'workspace/didChangeConfiguration' after init #3023
Conversation
Do not change |
c3bf436
to
7122c44
Compare
Do not change |
Okay bot idk what to tell you, I didn't modify that file. |
Edit: the very first commit that was pushed got it right. Something is broken. |
7122c44
to
8421089
Compare
Do not change |
@tpope Maybe I misunderstood your hint, but this is still failing...? |
8421089
to
29f7d51
Compare
Do not change |
I don't think that's correct; you should never edit these files and instead let automation handle it. Only make changes to the |
The comment from the bot is misleading, apparently you're not supposed to change doc/server_configurations.md or doc/server_configurations.txt. I'll make a PR to clarify this point. |
29f7d51
to
d7d5591
Compare
Neovim does it automatically after init. Ref. neovim/nvim-lspconfig#3023
Since neovim/neovim#18847 there's no need to send the
workspace/didChangeConfiguration
manually after initialization, since neovim will automagically do it.This PR removes documentation references recommending this behaviour, together with the implementation handling the redundant action (I might have missed places so please review carefully).