Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: let core handle 'workspace/didChangeConfiguration' after init #3023

Merged
merged 1 commit into from
Feb 24, 2024

Conversation

MariaSolOs
Copy link
Member

Since neovim/neovim#18847 there's no need to send the workspace/didChangeConfiguration manually after initialization, since neovim will automagically do it.

This PR removes documentation references recommending this behaviour, together with the implementation handling the redundant action (I might have missed places so please review carefully).

@MariaSolOs MariaSolOs requested a review from glepnir as a code owner February 24, 2024 03:27
Copy link
Contributor

Do not change server_configurations.md directly. Edit the lua source file instead. See https://github.com/neovim/nvim-lspconfig/blob/master/CONTRIBUTING.md#generating-docs

Copy link
Contributor

Do not change server_configurations.md directly. Edit the lua source file instead. See https://github.com/neovim/nvim-lspconfig/blob/master/CONTRIBUTING.md#generating-docs

@MariaSolOs
Copy link
Member Author

Do not change server_configurations.md directly. Edit the lua source file instead. See https://github.com/neovim/nvim-lspconfig/blob/master/CONTRIBUTING.md#generating-docs

Okay bot idk what to tell you, I didn't modify that file.

@tpope
Copy link

tpope commented Feb 24, 2024

Do not change server_configurations.md directly. Edit the lua source file instead. See https://github.com/neovim/nvim-lspconfig/blob/master/CONTRIBUTING.md#generating-docs

Okay bot idk what to tell you, I didn't modify that file.

The wording is backwards in this case. You should change that file by regenerating the docs.

Edit: the very first commit that was pushed got it right. Something is broken.

Copy link
Contributor

Do not change server_configurations.md directly. Edit the lua source file instead. See https://github.com/neovim/nvim-lspconfig/blob/master/CONTRIBUTING.md#generating-docs

@MariaSolOs
Copy link
Member Author

The wording is backwards in this case. You should change that file by regenerating the docs.

@tpope Maybe I misunderstood your hint, but this is still failing...?

@tpope
Copy link

tpope commented Feb 24, 2024

7122c44 changes doc/server_configurations.txt only. The force push that clobbered it, 8421089, changes doc/server_configurations.md only. Change both files in the same commit and I bet you'll see green.

Copy link
Contributor

Do not change server_configurations.md directly. Edit the lua source file instead. See https://github.com/neovim/nvim-lspconfig/blob/master/CONTRIBUTING.md#generating-docs

@clason
Copy link
Member

clason commented Feb 24, 2024

7122c44 changes doc/server_configurations.txt only. The force push that clobbered it, 8421089, changes doc/server_configurations.md only. Change both files in the same commit and I bet you'll see green.

I don't think that's correct; you should never edit these files and instead let automation handle it. Only make changes to the .lua file; everything else is autogenerated from that ("we'll fix it in post").

@dundargoc
Copy link
Member

The comment from the bot is misleading, apparently you're not supposed to change doc/server_configurations.md or doc/server_configurations.txt. I'll make a PR to clarify this point.

@clason clason merged commit d0a4176 into neovim:master Feb 24, 2024
9 checks passed
@MariaSolOs MariaSolOs deleted the config-notification branch February 24, 2024 18:06
antoineco added a commit to antoineco/dotfiles that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants