Skip to content

Commit

Permalink
Merge pull request #82 from neos/task/adjust-to-subscription-engine
Browse files Browse the repository at this point in the history
TASK: Adjust to subscription engine
  • Loading branch information
mhsdesign authored Dec 16, 2024
2 parents 55f3e1f + dd9fbca commit 92a4d82
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 10 deletions.
7 changes: 4 additions & 3 deletions Classes/CatchUpHook/DocumentUriPathProjectionHook.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,11 @@
use Neos\ContentRepository\Core\Feature\NodeModification\Event\NodePropertiesWereSet;
use Neos\ContentRepository\Core\Feature\NodeMove\Event\NodeAggregateWasMoved;
use Neos\ContentRepository\Core\Feature\NodeRemoval\Event\NodeAggregateWasRemoved;
use Neos\ContentRepository\Core\Projection\CatchUpHookInterface;
use Neos\ContentRepository\Core\Projection\CatchUpHook\CatchUpHookInterface;
use Neos\ContentRepository\Core\SharedModel\ContentRepository\ContentRepositoryId;
use Neos\ContentRepository\Core\SharedModel\Node\NodeAddress;
use Neos\ContentRepository\Core\SharedModel\Node\NodeAggregateId;
use Neos\ContentRepository\Core\Subscription\SubscriptionStatus;
use Neos\EventStore\Model\EventEnvelope;
use Neos\Neos\FrontendRouting\Exception\NodeNotFoundException;
use Neos\Neos\FrontendRouting\Projection\DocumentNodeInfo;
Expand All @@ -31,7 +32,7 @@ public function __construct(
) {
}

public function onBeforeCatchUp(): void
public function onBeforeCatchUp(SubscriptionStatus $subscriptionStatus): void
{
// Nothing to do here
}
Expand All @@ -56,7 +57,7 @@ public function onAfterEvent(EventInterface $eventInstance, EventEnvelope $event
};
}

public function onBeforeBatchCompleted(): void
public function onAfterBatchCompleted(): void
{
// Nothing to do here
}
Expand Down
6 changes: 3 additions & 3 deletions Classes/CatchUpHook/DocumentUriPathProjectionHookFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

namespace Neos\RedirectHandler\NeosAdapter\CatchUpHook;

use Neos\ContentRepository\Core\Projection\CatchUpHookFactoryDependencies;
use Neos\ContentRepository\Core\Projection\CatchUpHookFactoryInterface;
use Neos\ContentRepository\Core\Projection\CatchUpHookInterface;
use Neos\ContentRepository\Core\Projection\CatchupHook\CatchUpHookFactoryDependencies;
use Neos\ContentRepository\Core\Projection\CatchupHook\CatchUpHookFactoryInterface;
use Neos\ContentRepository\Core\Projection\CatchupHook\CatchUpHookInterface;

Check failure on line 7 in Classes/CatchUpHook/DocumentUriPathProjectionHookFactory.php

View workflow job for this annotation

GitHub Actions / build (8.2)

Interface Neos\ContentRepository\Core\Projection\CatchUpHook\CatchUpHookInterface referenced with incorrect case: Neos\ContentRepository\Core\Projection\CatchupHook\CatchUpHookInterface.

Check failure on line 7 in Classes/CatchUpHook/DocumentUriPathProjectionHookFactory.php

View workflow job for this annotation

GitHub Actions / build (8.3)

Interface Neos\ContentRepository\Core\Projection\CatchUpHook\CatchUpHookInterface referenced with incorrect case: Neos\ContentRepository\Core\Projection\CatchupHook\CatchUpHookInterface.
use Neos\Neos\FrontendRouting\Projection\DocumentUriPathFinder;
use Neos\RedirectHandler\NeosAdapter\Service\NodeRedirectService;

Expand Down
8 changes: 4 additions & 4 deletions Tests/Behavior/Features/Bootstrap/FeatureContext.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
use Neos\Behat\FlowBootstrapTrait;
use Neos\Behat\FlowEntitiesTrait;
use Neos\ContentRepository\BehavioralTests\TestSuite\Behavior\CRBehavioralTestsSubjectProvider;
use Neos\ContentRepository\BehavioralTests\TestSuite\Behavior\GherkinPyStringNodeBasedNodeTypeManagerFactory;
use Neos\ContentRepository\BehavioralTests\TestSuite\Behavior\GherkinTableNodeBasedContentDimensionSourceFactory;
use Neos\ContentRepository\Core\ContentRepository;
use Neos\ContentRepository\Core\Factory\ContentRepositoryServiceFactoryInterface;
use Neos\ContentRepository\Core\Factory\ContentRepositoryServiceInterface;
use Neos\ContentRepository\Core\SharedModel\ContentRepository\ContentRepositoryId;
use Neos\ContentRepository\TestSuite\Behavior\Features\Bootstrap\CRTestSuiteTrait;
use Neos\ContentRepository\TestSuite\Fakes\FakeContentDimensionSourceFactory;
use Neos\ContentRepository\TestSuite\Fakes\FakeNodeTypeManagerFactory;
use Neos\ContentRepositoryRegistry\ContentRepositoryRegistry;

require_once(__DIR__ . '/../../../../../../Neos/Neos.Neos/Tests/Behavior/Features/Bootstrap/RoutingTrait.php');
Expand Down Expand Up @@ -47,8 +47,8 @@ protected function createContentRepository(
): ContentRepository {
$this->contentRepositoryRegistry->resetFactoryInstance($contentRepositoryId);
$contentRepository = $this->contentRepositoryRegistry->get($contentRepositoryId);
GherkinTableNodeBasedContentDimensionSourceFactory::reset();
GherkinPyStringNodeBasedNodeTypeManagerFactory::reset();
FakeContentDimensionSourceFactory::reset();
FakeNodeTypeManagerFactory::reset();

return $contentRepository;
}
Expand Down

0 comments on commit 92a4d82

Please sign in to comment.