Allow to set some PGC_SUSET GUCs from db owner #340
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not needed. Patch anon extension instead and use functions to set GUCs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on anon ext support (neondatabase/neon#6272), I bumped into superuser only GUCs, ie.
i.e.
DefineCustomStringVariable
(
"anon.salt",
"The salt value used for the pseudonymizing functions",
"",
&guc_anon_salt,
"",
PGC_SUSET,
GUC_SUPERUSER_ONLY,
documentation
We don't provide superuser access in neon, only neon_superuser.
So it is impossible for clients to use this extension with dynamic masking.
It is not secure to simply change it to PGC_USERSET.
I propose to allow some PGC_SUSET GUCs to be set by db_owner.
This is not the most beautiful solution, but it seem to work.