Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: don't set LD_LIBRARY_PATH #10321

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

jcsp
Copy link
Collaborator

@jcsp jcsp commented Jan 9, 2025

Problem

This was causing storage controller to still use neon-built libpq instead of vanilla libpq.

Since #10269 we have a vanilla postgres in the system path -- anything that wants a postgres library will use that.

Summary of changes

  • Remove LD_LIBRARY_PATH assignment in Dockerfile

Since #10269 we have a vanilla
postgres in the system path -- anything that wants a postgres library
will use that.
@jcsp jcsp requested review from erikgrinaker and rahulinux January 9, 2025 09:57
@rahulinux
Copy link
Contributor

Should we set it explicitly rather than using the default setting for the storage controller? I suspect that changing the default might break something else. https://neondb.slack.com/archives/C033RQ5SPDH/p1736416908939979?thread_ts=1736413779.069519&cid=C033RQ5SPDH

@rahulinux
Copy link
Contributor

Should we set it explicitly rather than using the default setting for the storage controller? I suspect that changing the default might break something else. neondb.slack.com/archives/C033RQ5SPDH/p1736416908939979?thread_ts=1736413779.069519&cid=C033RQ5SPDH

discussed here https://neondb.slack.com/archives/C033RQ5SPDH/p1736417720516929?thread_ts=1736413779.069519&cid=C033RQ5SPDH

@jcsp jcsp enabled auto-merge January 9, 2025 10:23
Copy link

github-actions bot commented Jan 9, 2025

7286 tests run: 6919 passed, 0 failed, 367 skipped (full report)


Flaky tests (3)

Postgres 17

Postgres 15

Code coverage* (full report)

  • functions: 31.1% (8411 of 27005 functions)
  • lines: 47.8% (66780 of 139607 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
5342c0f at 2025-01-09T11:56:19.542Z :recycle:

@jcsp jcsp added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit 5baa4e7 Jan 9, 2025
86 checks passed
@jcsp jcsp deleted the jcsp/docker-no-ld-library-path branch January 9, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants