Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pageserver): support inherited sparse keyspace #10313

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Jan 8, 2025

Problem

In preparation to #9516. We need to store rel size and directory data in the sparse keyspace, but it does not support inheritance yet.

Summary of changes

Add a new type of keyspace "sparse but inherited" into the system.

On the read path: we don't remove the key range when we descend into the ancestor. The search will stop when (1) the full key range is covered by image layers (which has already been implemented before), or (2) we reach the end of the ancestor chain.

@skyzh skyzh requested a review from a team as a code owner January 8, 2025 20:05
@skyzh skyzh requested review from jcsp and VladLazar January 8, 2025 20:05
@skyzh skyzh marked this pull request as draft January 8, 2025 20:15
@skyzh
Copy link
Member Author

skyzh commented Jan 8, 2025

handling image layers seems a little bit tricker, I'll need to revisit and add more tests

Copy link

github-actions bot commented Jan 8, 2025

7271 tests run: 6907 passed, 0 failed, 364 skipped (full report)


Flaky tests (1)

Postgres 16

  • test_physical_replication_config_mismatch_max_locks_per_transaction: release-arm64

Code coverage* (full report)

  • functions: 32.5% (8042 of 24739 functions)
  • lines: 47.8% (66915 of 139938 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
c857660 at 2025-01-09T21:19:32.692Z :recycle:

@skyzh skyzh force-pushed the skyzh/sparse-inherit branch from 4caadbd to 0fa38d4 Compare January 9, 2025 20:00
Signed-off-by: Alex Chi Z <[email protected]>
@skyzh skyzh marked this pull request as ready for review January 9, 2025 20:21
@skyzh
Copy link
Member Author

skyzh commented Jan 9, 2025

ready for review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant