-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LFC prewarming with only light locking #10312
Draft
MMeent
wants to merge
15
commits into
main
Choose a base branch
from
MMeent/lfc-prewarm-light-locks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+1,440
−179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MMeent
force-pushed
the
MMeent/lfc-prewarm-light-locks
branch
from
January 8, 2025 18:56
985f2be
to
1a391eb
Compare
7304 tests run: 6936 passed, 4 failed, 364 skipped (full report)Failures on Postgres 15
Failures on Postgres 14
Flaky tests (3)Postgres 16
Postgres 14
Test coverage report is not availableThe comment gets automatically updated with the latest test results
0f93d01 at 2025-01-09T22:46:06.378Z :recycle: |
This reduces contention and data copy operations required.
Now, we can have multiple chunks worth of IO happening, which reduces stalls caused by IO.
…y replica prewarming
MMeent
force-pushed
the
MMeent/lfc-prewarm-light-locks
branch
from
January 9, 2025 14:56
3410a14
to
06c887b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We want to prewarm the LFC, preferably without blocking any other processes (or at least blocking the least amount of processes
Summary of changes
See
file_cache_internal.h
for implementation details.