storage_controller: make long reconcile threshold a value (#111)

neondatabase · Oct 31, 2024 · fdc3d7c · fdc3d7c
1 parent 496ba6e
commit fdc3d7c
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 2 deletions.
diff --git a/charts/neon-storage-controller/Chart.yaml b/charts/neon-storage-controller/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v2
 name: neon-storage-controller
 description: Neon storage controller
 type: application
-version: 1.1.4
+version: 1.1.5
 appVersion: "0.1.0"
 kubeVersion: "^1.18.x-x"
 home: https://neon.tech

diff --git a/charts/neon-storage-controller/README.md b/charts/neon-storage-controller/README.md
@@ -1,6 +1,6 @@
 # neon-storage-controller
 
-![Version: 1.1.4](https://img.shields.io/badge/Version-1.1.4-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) [![Lint and Test Charts](https://github.com/neondatabase/helm-charts/actions/workflows/lint-test.yaml/badge.svg)](https://github.com/neondatabase/helm-charts/actions/workflows/lint-test.yaml)
+![Version: 1.1.5](https://img.shields.io/badge/Version-1.1.5-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) [![Lint and Test Charts](https://github.com/neondatabase/helm-charts/actions/workflows/lint-test.yaml/badge.svg)](https://github.com/neondatabase/helm-charts/actions/workflows/lint-test.yaml)
 
 Neon storage controller
 
@@ -67,6 +67,7 @@ Kubernetes: `^1.18.x-x`
 | settings.controlPlaneJwtToken | string | `""` |  |
 | settings.databaseUrl | string | `""` |  |
 | settings.jwtToken | string | `""` |  |
+| settings.longReconcileThreshold | string | `"30min"` | If a reconciliation takes longer than this, bump an alerting metric |
 | settings.peerJwtToken | string | `""` | JWT token for authentication with other storage controller instances |
 | settings.publicKey | string | `""` |  |
 | settings.sentryEnvironment | string | `"development"` | "development" or "production". It will be visible in sentry in order to filter issues |

diff --git a/charts/neon-storage-controller/templates/deployment.yaml b/charts/neon-storage-controller/templates/deployment.yaml
@@ -71,6 +71,10 @@ spec:
           {{- if .Values.settings.startAsCandidate }}
             - --start-as-candidate
           {{- end }}
+          {{- if .Values.settings.longReconcileThreshold }}
+            - --long-reconcile-threshold
+            - {{ .Values.settings.longReconcileThreshold | quote }}
+          {{- end }}
           env:
             - name: LD_LIBRARY_PATH
               value: "/usr/local/v16/lib"

diff --git a/charts/neon-storage-controller/values.yaml b/charts/neon-storage-controller/values.yaml
@@ -42,6 +42,8 @@ settings:
   chaosInterval: ""
   # -- When set to True, restart the service gracefully
   startAsCandidate: false
+  # -- If a reconciliation takes longer than this, bump an alerting metric
+  longReconcileThreshold: "30min"
 
 
 # Enable auto register to control plane