Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typename fix #6041

Open
wants to merge 5 commits into
base: lts
Choose a base branch
from
Open

Typename fix #6041

wants to merge 5 commits into from

Conversation

MacondoExpress
Copy link
Contributor

@MacondoExpress MacondoExpress commented Mar 4, 2025

Description

This PR fixes bug report #6031 that caused typename filters not correctly working on connection fields.
This was caused by an interface branch condition for parsing an interface, which requires the interface source for any concrete entities parsed.

Closes #6031

Copy link

changeset-bot bot commented Mar 4, 2025

🦋 Changeset detected

Latest commit: 20bbbce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@neo4j/graphql Patch
@neo4j/graphql-ogm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@neo4j-team-graphql
Copy link
Collaborator

neo4j-team-graphql commented Mar 4, 2025

Performance Report

No Performance Changes

Show Full Table
name dbHits old dbHits time (ms) old time (ms) maxRows
aggregations.TopLevelAggregate 3404 3404 37 44 1134
aggregations.TopLevelAggregateWithMultipleFields 6802 6802 46 72 1134
aggregations.NestedAggregation 15407 15407 70 89 2174
aggregations.AggregationWithWhere 10833 10833 41 72 2174
aggregations.AggregationWhereWithinNestedRelationships 20097917 20097917 1925 2110 2008534
aggregations.AggregationWhereWithinNestedConnections 20097917 20097917 1933 2056 2008534
aggregations.NestedCountFromMovieToActors 8603 8603 33 50 2174
aggregations.NestedCountFromActorsToMovie 8791 8791 41 42 2174
aggregations.DeeplyNestedCount 10052335 10052335 2542 2663 2008534
aggregations.InterfacesAggregations 6242 6242 45 58 2080
aggregations.InterfacesAggregationsWithTwoFields 11444 11444 72 144 2080
batch-create.BatchCreate 4200 4200 114 145 600
batch-create.BatchCreateSmall 77 77 51 69 11
connect.createAndConnect 6433 6433 187 180 3003
connections.Connection 12951 12951 65 69 2174
connections.NestedConnection 37705 37705 118 171 4516
create.SimpleMutation 7 7 51 61 1
cypher-directive.TopLevelMutationDirective 1135 1135 31 29 1134
delete.SimpleDelete 19401 19401 702 739 1040
delete.NestedDeleteInUpdate 16844 16844 134 142 2040
2871.NestedRelationshipFilter 19869 19769 61 66 4467
2925.SingleRelationshipFilter 5245 5245 42 49 1040
2925.NestedSingleRelationshipFilter 17641 17626 69 107 2174
2925.SingleRelationshipRequiredFilter 5201 5201 37 43 1040
2925.NestedSingleRelationshipRequiredFilter 9361 9361 54 60 1040
query.SimpleQuery 3121 3121 21 25 1040
query.SimpleQueryWithRelationship 15031 15031 37 53 2174
query.QueryWhere 8594 8585 32 39 2164
query.SimpleQueryWithNestedWhere 8743 8734 45 58 2164
query.Nested 10084891 10084891 9129 9056 2008534
query.NestedWithFilter 10064992 10064992 6667 6649 2004000
query.OrFilterOnRelationships 37426 37201 154 156 2171
query.OrFilterOnRelationshipsAndNested 27427 27236 186 216 2171
query.QueryWithNestedIn 14921 14951 49 57 2107
query.NestedConnectionWhere 8703 8703 51 62 2174
query.DeeplyNestedConnectionWhere 8803 8793 68 91 2174
query.DeeplyNestedWithRelationshipFilters 17489 17489 123 150 1596
query.NestedWithRelationshipSingleFilters 3808 3808 144 221 1134
query.Fulltext 64 64 29 40 16
query.FulltextWithNestedQuery 516 516 40 46 84
sorting-and-cypher.TopLevelSortWithCypher 12961 12961 39 44 2174
sorting-and-cypher.TopLevelConnectionSortWithCypher 12961 12961 58 94 2174
sorting-and-cypher.TopLevelSortWithCypherWithNested 13096 13096 65 68 2174
sorting-and-cypher.TopLevelConnectionSortWithCypherWithNested 13096 13096 92 98 2174
sorting-and-cypher.TopLevelSortWithExpensiveCypher 13708 13653 98 129 2174
sorting-and-cypher.TopLevelConnectionSortWithExpensiveCypher 13266 13266 121 127 2174
sorting.SortMultipleTypes 3436 3436 85 89 1040
sorting.SortMultipleTypesWithCypherWithCypher 13321 13321 100 111 2174
sorting.SortOnNestedFields 12951 12951 41 52 2174
sorting.SortDeeplyNestedFields 39785 39785 73 95 4516
sorting.ConnectionWithSort 3271 3271 72 85 1040
unions.SimpleUnionQuery 321 321 56 63 35
unions.SimpleUnionQueryWithMissingFields 293 293 53 57 35
unions.NestedUnion 309975 309975 257 266 33033
unions.NestedUnionWithMissingFields 283949 283949 250 268 33033
update.NestedUpdate 14137 14137 108 113 2002

Old Schema Generation: 26.720s
Schema Generation: 26.989s
Old Subgraph Schema Generation: 26.953s
Subgraph Schema Generation: 27.205s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants