Validation rules refactor and included new errors for when the directive node is expected but missing #5963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pes annotated with the node node directive, added the nodeMissingValidation to the validation rules
|
angrykoala
requested changes
Jan 28, 2025
packages/graphql/src/schema/validation/Neo4jValidationContext.ts
Outdated
Show resolved
Hide resolved
packages/graphql/src/schema/validation/Neo4jValidationContext.ts
Outdated
Show resolved
Hide resolved
packages/graphql/src/schema/validation/custom-rules/valid-types/valid-field-types.ts
Outdated
Show resolved
Hide resolved
packages/graphql/src/schema/validation/custom-rules/utils/same-type-argument-as-field.ts
Show resolved
Hide resolved
packages/graphql/src/schema/validation/custom-rules/directives/authentication.ts
Show resolved
Hide resolved
packages/graphql/src/schema/validation/custom-rules/directives/authentication.ts
Outdated
Show resolved
Hide resolved
packages/graphql/src/schema/validation/custom-rules/directives/coalesce.ts
Outdated
Show resolved
Hide resolved
packages/graphql/src/schema/validation/custom-rules/directives/relationship.ts
Show resolved
Hide resolved
packages/graphql/src/schema/validation/validate-document.test.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title, this PR refactor the way how the validation are done.
The previous validation functions associated with each directive are now moved to their own Rule per directive.
It also includes a list of new rules for when the
@nodedirective is expected but missing, for instance, when a directive expected to be used within a@nodetype is found but the@nodedirective is not.Nice follow-ups (out of the scope of PR).
The list of directives tested was increased but is still not comprehensive; for instance, no validation rules were present for the Vector directive.
The new errors include invalid usage when the
@nodedirective is not found. However, it does not cover cases when the type of a field is expected to reference an Object type that contains the@nodedirective; This could be particularly useful for identifying mistakes when the@relationshipand@cyphertarget is not annotated as a@node.