Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5515 #5524

Conversation

angrykoala
Copy link
Member

Description

This PR solves #5515, in which filters for authorization was not properly composed in delete operations

Copy link

changeset-bot bot commented Sep 2, 2024

🦋 Changeset detected

Latest commit: 5d0db54

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@neo4j/graphql Patch
@neo4j/graphql-ogm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@neo4j-team-graphql
Copy link
Collaborator

Performance Report

No Performance Changes

Show Full Table
name dbHits old dbHits time (ms) old time (ms) maxRows
aggregations.TopLevelAggregate 3404 3404 35 53 1134
aggregations.TopLevelAggregateWithMultipleFields 6802 6802 43 66 1134
aggregations.NestedAggregation 15407 15407 60 109 2174
aggregations.AggregationWithWhere 10833 10833 38 68 2174
aggregations.AggregationWhereWithinNestedRelationships 20097917 20097917 2099 2292 2008534
aggregations.AggregationWhereWithinNestedConnections 20097917 20097917 2099 2252 2008534
aggregations.NestedCountFromMovieToActors 8603 8603 36 40 2174
aggregations.NestedCountFromActorsToMovie 8791 8791 36 45 2174
aggregations.DeeplyNestedCount 10052335 10052335 2356 2641 2008534
aggregations.InterfacesAggregations 6242 6242 47 98 2080
aggregations.InterfacesAggregationsWithTwoFields 11444 11444 81 109 2080
batch-create.BatchCreate 4200 4200 138 161 600
batch-create.BatchCreateSmall 77 77 56 62 11
connect.createAndConnect 6433 6433 123 168 3003
connections.Connection 12951 12951 64 73 2174
connections.NestedConnection 37705 37705 125 163 4516
create.SimpleMutation 7 7 50 66 1
cypher-directive.TopLevelMutationDirective 1135 1135 24 27 1134
delete.SimpleDelete 19401 19401 624 702 1040
delete.NestedDeleteInUpdate 16844 16844 116 168 1183
2871.NestedRelationshipFilter 19632 19632 51 58 4395
2925.SingleRelationshipFilter 5245 5245 37 47 1040
2925.NestedSingleRelationshipFilter 17641 17641 70 104 2174
2925.SingleRelationshipRequiredFilter 5201 5201 36 46 1040
2925.NestedSingleRelationshipRequiredFilter 9361 9361 56 69 1040
query.SimpleQuery 3121 3121 18 33 1040
query.SimpleQueryWithRelationship 15031 15031 37 55 2174
query.QueryWhere 8564 8564 32 43 2154
query.SimpleQueryWithNestedWhere 8713 8713 45 52 2154
query.Nested 10084891 10084891 6920 6951 2008534
query.NestedWithFilter 10064992 10064992 7001 6505 2004000
query.OrFilterOnRelationships 36664 36443 135 166 1933
query.OrFilterOnRelationshipsAndNested 26737 26874 199 230 1933
query.QueryWithNestedIn 14126 14093 49 61 1842
query.NestedConnectionWhere 8703 8703 48 59 2174
query.DeeplyNestedConnectionWhere 8702 8702 99 161 2174
query.DeeplyNestedWithRelationshipFilters 17357 17357 116 170 1552
query.NestedWithRelationshipSingleFilters 3808 3808 188 200 1134
query.Fulltext 64 64 36 35 16
query.FulltextWithNestedQuery 516 516 41 47 84
sorting-and-cypher.TopLevelSortWithCypher 12961 12961 37 53 2174
sorting-and-cypher.TopLevelConnectionSortWithCypher 12961 12961 61 65 2174
sorting-and-cypher.TopLevelSortWithCypherWithNested 13096 13096 53 60 2174
sorting-and-cypher.TopLevelConnectionSortWithCypherWithNested 13096 13096 91 105 2174
sorting-and-cypher.TopLevelSortWithExpensiveCypher 13725 13720 103 115 2174
sorting-and-cypher.TopLevelConnectionSortWithExpensiveCypher 13266 13266 98 107 2174
sorting.SortMultipleTypes 3436 3436 79 93 1040
sorting.SortMultipleTypesWithCypherWithCypher 13321 13321 95 120 2174
sorting.SortOnNestedFields 12951 12951 44 51 2174
sorting.SortDeeplyNestedFields 39785 39785 86 93 4516
sorting.ConnectionWithSort 3271 3271 69 75 1040
unions.SimpleUnionQuery 321 321 53 63 35
unions.SimpleUnionQueryWithMissingFields 293 293 52 58 35
unions.NestedUnion 309975 309975 282 279 33033
unions.NestedUnionWithMissingFields 283949 283949 244 260 33033
update.NestedUpdate 14137 14137 98 108 2002

Old Schema Generation: 27.922s
Schema Generation: 27.818s
Old Subgraph Schema Generation: 29.000s
Subgraph Schema Generation: 28.514s

@angrykoala angrykoala merged commit cafa339 into dev Sep 3, 2024
81 of 82 checks passed
@angrykoala angrykoala deleted the 5515-neo4jerror-variable-this-not-defined-when-auth-rules-are-defined branch September 3, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Neo4jError: Variable this not defined when auth rules are defined
3 participants