Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 5497 #5507

Conversation

angrykoala
Copy link
Member

Fix generated cypher for disconnect operations with filters #5497

Copy link

changeset-bot bot commented Aug 29, 2024

🦋 Changeset detected

Latest commit: 461ee3a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@neo4j/graphql Patch
@neo4j/graphql-ogm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

darrellwarde
darrellwarde previously approved these changes Aug 29, 2024
@angrykoala angrykoala force-pushed the 5497-neo4jerror-invalid-input-where-expected-when-using-auth-in-specific-scenarios-2 branch from 8377972 to 461ee3a Compare August 29, 2024 14:38
@neo4j-team-graphql
Copy link
Collaborator

neo4j-team-graphql commented Aug 29, 2024

Performance Report

No Performance Changes

Show Full Table
name dbHits old dbHits time (ms) old time (ms) maxRows
aggregations.TopLevelAggregate 3404 3404 41 56 1134
aggregations.TopLevelAggregateWithMultipleFields 6802 6802 50 59 1134
aggregations.NestedAggregation 15407 15407 59 86 2174
aggregations.AggregationWithWhere 10833 10833 38 64 2174
aggregations.AggregationWhereWithinNestedRelationships 20097917 20097917 2204 2352 2008534
aggregations.AggregationWhereWithinNestedConnections 20097917 20097917 2266 2196 2008534
aggregations.NestedCountFromMovieToActors 8603 8603 34 42 2174
aggregations.NestedCountFromActorsToMovie 8791 8791 34 39 2174
aggregations.DeeplyNestedCount 10052335 10052335 2266 2510 2008534
aggregations.InterfacesAggregations 6242 6242 50 51 2080
aggregations.InterfacesAggregationsWithTwoFields 11444 11444 70 90 2080
batch-create.BatchCreate 4200 4200 126 161 600
batch-create.BatchCreateSmall 77 77 61 67 11
connect.createAndConnect 6433 6433 125 167 3003
connections.Connection 12951 12951 73 71 2174
connections.NestedConnection 37705 37705 130 145 4516
create.SimpleMutation 7 7 52 68 1
cypher-directive.TopLevelMutationDirective 1135 1135 25 28 1134
delete.SimpleDelete 19401 19401 648 685 1040
delete.NestedDeleteInUpdate 16844 16844 120 147 1183
2871.NestedRelationshipFilter 19632 19632 57 62 4395
2925.SingleRelationshipFilter 5245 5245 36 56 1040
2925.NestedSingleRelationshipFilter 17641 17641 74 100 2174
2925.SingleRelationshipRequiredFilter 5201 5201 39 46 1040
2925.NestedSingleRelationshipRequiredFilter 9361 9361 53 67 1040
query.SimpleQuery 3121 3121 29 24 1040
query.SimpleQueryWithRelationship 15031 15031 46 47 2174
query.QueryWhere 8564 8564 33 39 2154
query.SimpleQueryWithNestedWhere 8713 8713 45 54 2154
query.Nested 10084891 10084891 6821 6959 2008534
query.NestedWithFilter 10064992 10064992 6746 6531 2004000
query.OrFilterOnRelationships 36673 36464 144 174 1936
query.OrFilterOnRelationshipsAndNested 26746 26895 227 220 1936
query.QueryWithNestedIn 14138 14114 67 64 1846
query.NestedConnectionWhere 8703 8703 56 121 2174
query.DeeplyNestedConnectionWhere 8702 8702 73 109 2174
query.DeeplyNestedWithRelationshipFilters 17357 17357 195 185 1552
query.NestedWithRelationshipSingleFilters 3808 3808 172 194 1134
query.Fulltext 64 64 32 36 16
query.FulltextWithNestedQuery 516 516 43 51 84
sorting-and-cypher.TopLevelSortWithCypher 12961 12961 41 47 2174
sorting-and-cypher.TopLevelConnectionSortWithCypher 12961 12961 59 67 2174
sorting-and-cypher.TopLevelSortWithCypherWithNested 13096 13096 57 61 2174
sorting-and-cypher.TopLevelConnectionSortWithCypherWithNested 13096 13096 88 100 2174
sorting-and-cypher.TopLevelSortWithExpensiveCypher 13725 13720 104 120 2174
sorting-and-cypher.TopLevelConnectionSortWithExpensiveCypher 13266 13266 95 111 2174
sorting.SortMultipleTypes 3436 3436 96 109 1040
sorting.SortMultipleTypesWithCypherWithCypher 13321 13321 101 125 2174
sorting.SortOnNestedFields 12951 12951 47 59 2174
sorting.SortDeeplyNestedFields 39785 39785 75 114 4516
sorting.ConnectionWithSort 3271 3271 70 89 1040
unions.SimpleUnionQuery 321 321 56 63 35
unions.SimpleUnionQueryWithMissingFields 293 293 52 63 35
unions.NestedUnion 309975 309975 252 302 33033
unions.NestedUnionWithMissingFields 283949 283949 246 263 33033
update.NestedUpdate 14137 14137 104 102 2002

Old Schema Generation: 27.995s
Schema Generation: 27.795s
Old Subgraph Schema Generation: 29.405s
Subgraph Schema Generation: 28.762s

@angrykoala angrykoala merged commit 379a938 into dev Aug 29, 2024
80 checks passed
@angrykoala angrykoala deleted the 5497-neo4jerror-invalid-input-where-expected-when-using-auth-in-specific-scenarios-2 branch August 29, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Neo4jError: Invalid input 'WHERE': expected when using auth in specific scenarios - 2
4 participants